-
Notifications
You must be signed in to change notification settings - Fork 17.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
cmd/compile: unnecessary nil check after store #19148
Comments
See #18725 , I think the fix for that bug caused this to happen. The problem is the two nil checks are in the same block and the values in a block are unordered during nil check elim. Might be fixed by https://go-review.googlesource.com/c/35496/ |
Yes, CL https://go-review.googlesource.com/c/35496/ fixes it. With the CL applied, it generates
|
CL https://go-review.googlesource.com/c/35496/ is submitted. Closing. |
At tip (79f6a5c) it looks like nil checks don't always get eliminated when a load that follows a store is eliminated. Not sure if this is a known issue:
compiles to (on amd64):
I see a similar issue on s390x.
The text was updated successfully, but these errors were encountered: