-
Notifications
You must be signed in to change notification settings - Fork 17.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
cmd/go: go1.8 release binaries for linux_amd64 error when building test dependencies with race mode enabled. #19133
Comments
I added some debugging output what information is used to compute buildIDs by the computeBuildID function. Here's what I got for the
|
Seems like it's caused by the default value of And it affects package dependencies list: |
CL https://golang.org/cl/37594 mentions this issue. |
CL https://golang.org/cl/37598 mentions this issue. |
* Switch to gRPC for AuthFE -> Users RPCs - Use common/server in users service - Add gRPC service for Lookup* operations - Upgrade to go1.8 - Refactor users client library so the HTTP client gives us the same interface as the gRPC one. - Split auth caching out into so it can be used with web or gRPC client * Vendor gRPC etc * Temporarily disable race tests due to golang/go#19133 * Instansiate gRPC client. * Add graceful shutdown to common.Server. * Review feedback * Update integration tests to go1.8 * Split the gRPC code out into separate package * Fix lint & test * Add gRPC server middleware to correctly propagate error codes * Intercept gRPC errors in the client and tranlate them into something the middleware understands. * Fix lint * Make error propagation cleaner. * Fix lint:
CL https://golang.org/cl/39617 mentions this issue. |
… 'go test -i -race' Manual port of CL 37598 (submitted for Go 1.9) to Go 1.8.1. Fixes #19133. Fixes #19151. Change-Id: I51707ea35068a393022f554b391ee2638dba16b5 Reviewed-on: https://go-review.googlesource.com/39617 Run-TryBot: Russ Cox <rsc@golang.org> TryBot-Result: Gobot Gobot <gobot@golang.org> Reviewed-by: Austin Clements <austin@google.com>
In the 1.8 binary releases for linux,
go test -i -race
tries to re-build some packages from the standard library. If your go install is not writable, it will error trying to open the$pkg.a
files for writing.What version of Go are you using (
go version
)?Today's release:
go version go1.8 linux/amd64
Specifically, the binary release from:
https://storage.googleapis.com/golang/go1.8.linux-amd64.tar.gz
Sha384sum:
5cf34c2335341febb707008ede937729c5cf09f66c98e11065ecc58f945fc7d95e1ed10c1d8de765591de5cf20c16457 go1.8.linux-amd64.tar.gz
What operating system and processor architecture are you using (
go env
)?linux_amd64
What did you do?
Given a
reproducer_test.go
file:I run `go test in several different modes:
go test ./...
-- passesgo test -race ./...
-- passesgo test -i ./...
-- passesgo test -i -race ./...
-- FAILSGo was installed by untar'ing the binary release. All of its uids are 0; all of its mtimes are as given by the tar headers.
The tarball is extracted in
/installpath
, andexport GOROOT=/installpath/go
applied to the environment.(Identical steps have been used to install a go1.7 binary release, which does not exhibit the problem.)
What did you expect to see?
All four of these test commands should pass. (All four commands work correctly on go1.7.)
What did you see instead?
Test with
-i
and-race
-mode gives the following error output:and exits with a 1.
Other notes
When encountering this on less minimal code, I've seen several other packages also listed as offenders, such as
crypto/subtle
for example. The five listed above are what comes up with the minimal reproducer -- these five packages are dependencies of thetesting
package.I thought perhaps this might be an issue from timestamps on the
.a
files being older than the relevant source files (I've made a mistake with an rsync command before that fubar'd that, and paid silly increases in compile time until I noticed and fixed it), but that doesn't appear to be the case, so I'm not sure what's going on here.The text was updated successfully, but these errors were encountered: