Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cmd/go: roll back StaleReason CL #19116

Closed
rsc opened this issue Feb 15, 2017 · 5 comments
Closed

cmd/go: roll back StaleReason CL #19116

rsc opened this issue Feb 15, 2017 · 5 comments
Labels
FrozenDueToAge
Milestone
Go1.9

Comments

@rsc
Copy link
Contributor

rsc commented Feb 15, 2017

CL https://go-review.googlesource.com/#/c/36944/ is for debugging the builders. It should be rolled back when done to avoid an API change.
@rsc rsc added this to the Go1.9 milestone Feb 15, 2017
@bradfitz
Copy link
Contributor

Also https://go-review.googlesource.com/c/37332/ which didn't reference a bug.
/cc @laboger

@bradfitz
Copy link
Contributor

Issue being debugged is #19062

@laboger
Copy link
Contributor

laboger commented Feb 22, 2017

I can roll back the StaleReason change and the crash_test.go change when we get this figured out.

@rsc
Copy link
Contributor Author

rsc commented Feb 22, 2017

Yes, no rush. I filed the bug so we wouldn't forget, but there's lots of time.

@gopherbot
Copy link

CL https://golang.org/cl/37382 mentions this issue.

@golang golang locked and limited conversation to collaborators Mar 1, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
FrozenDueToAge
Projects
None yet
Milestone
Go1.9
Development

No branches or pull requests
4 participants
@bradfitz @rsc @gopherbot @laboger