net/url: Parsing malformed URL does not result in error #19110
Labels
Milestone
Comments
|
I'm pretty sure this is working as intended. The format of a URL is more permissive than the conventional formatting of key=value&key=value query args. |
|
@bradfitz That makes sense - but then, shouldn't |
|
Looks intentional: func (u *URL) Query() Values {
v, _ := ParseQuery(u.RawQuery)
return v
}And we can't change the signature at this point due to go1compat. I suppose we could add a couple words of documentation to that method. |
|
CL https://golang.org/cl/37194 mentions this issue. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
What version of Go are you using (
go version)?go version go1.7.5 darwin/amd64What operating system and processor architecture are you using (
go env)?What did you do?
https://play.golang.org/p/qcpF1Vz3sY
What did you expect to see?
I expected the call to
url.Parse()to raise an error. Otherwise, I would expecttestURL.Query()to return an error, if the function signature allowed it.What did you see instead?
testURL.Query()silently drops malformed query parameters andurl.Parse()raises no error.The text was updated successfully, but these errors were encountered: