Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

x/review/git-codereview: Branchpoint command is not highlighted on godoc.org doc page #19077

Closed
alexbrainman opened this issue Feb 14, 2017 · 2 comments
Closed

x/review/git-codereview: Branchpoint command is not highlighted on godoc.org doc page #19077

alexbrainman opened this issue Feb 14, 2017 · 2 comments
Labels
FrozenDueToAge
Milestone
Unreleased

Comments

@alexbrainman
Copy link
Member

Look at https://godoc.org/golang.org/x/review/git-codereview.

I think Branchpoint command should be highlighted like others. But it is not.

Also see this output:

# godoc -html golang.org/x/review/git-codereview | grep h3
<h3 id="hdr-Single_Commit_Work_Branches">Single-Commit Work Branches</h3>
<h3 id="hdr-Multiple_Commit_Work_Branches">Multiple-Commit Work Branches</h3>
<h3 id="hdr-Reusing_Work_Branches">Reusing Work Branches</h3>
<h3 id="hdr-Command_Details">Command Details</h3>
<h3 id="hdr-Change">Change</h3>
<h3 id="hdr-Gofmt">Gofmt</h3>
<h3 id="hdr-Help">Help</h3>
<h3 id="hdr-Hooks">Hooks</h3>
<h3 id="hdr-Hook_Invoke">Hook-Invoke</h3>
<h3 id="hdr-Mail">Mail</h3>
<h3 id="hdr-Pending">Pending</h3>
<h3 id="hdr-Rebase_work">Rebase-work</h3>
<h3 id="hdr-Submit">Submit</h3>
<h3 id="hdr-Sync">Sync</h3>
<h3 id="hdr-Configuration">Configuration</h3>
# godoc -html golang.org/x/review/git-codereview | grep Branchpoint
Branchpoint
#

Sorry I had no time to investigate more.

Alex
@gopherbot gopherbot added this to the Unreleased milestone Mar 21, 2017
@meirf
Copy link
Contributor

meirf commented Jun 16, 2018

All other commands have this pattern:

Command title

Command description.

git codereview command ...

Branchpoint goes from title to command code without having a description, which disqualifies the title from being considered a header.

@gopherbot
Copy link

Change https://golang.org/cl/119339 mentions this issue: x/review/git-codereview: highlight branchpoint command

@golang golang locked and limited conversation to collaborators Jun 17, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
FrozenDueToAge
Projects
None yet
Milestone
Unreleased
Development

No branches or pull requests
3 participants
@meirf @gopherbot @alexbrainman