Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

all: code cleanup when dropping support for FreeBSD 9 or below #19072

Closed
mikioh opened this issue Feb 14, 2017 · 4 comments
Closed

all: code cleanup when dropping support for FreeBSD 9 or below #19072

mikioh opened this issue Feb 14, 2017 · 4 comments
Labels
FrozenDueToAge OS-FreeBSD
Milestone
Go1.10

Comments

@mikioh
Copy link
Contributor

mikioh commented Feb 14, 2017 •
edited

#Split from #19002. It's desirable to clean up the following when dropping support for FreeBSD 9 or below:
@bradfitz bradfitz added this to the Go1.9Maybe milestone Mar 21, 2017
@gopherbot
Copy link

CL https://golang.org/cl/38430 mentions this issue.

gopherbot pushed a commit that referenced this issue Mar 21, 2017
@bradfitz
syscall, os: fix FreeBSD 9 build
2730c17 
I broke FreeBSD 9 in https://golang.org/cl/38426 by using Pipe2.

We still want to support FreeBSD 9 for one last release (Go 1.9 will
be the last), and FreeBSD 9 doesn't have Pipe2.

So this still uses Pipe2, but falls back to Pipe on error.

Updates #18854
Updates #19072

Change-Id: I1de90fb83606c93fb84b4b86fba31e207a702835
Reviewed-on: https://go-review.googlesource.com/38430
Reviewed-by: Rob Pike <r@golang.org>
Reviewed-by: Ian Lance Taylor <iant@golang.org>
Run-TryBot: Brad Fitzpatrick <bradfitz@golang.org>
TryBot-Result: Gobot Gobot <gobot@golang.org>
@mikioh mikioh modified the milestones: Go1.10, Go1.9Maybe May 9, 2017
@gopherbot
Copy link

Change https://golang.org/cl/61470 mentions this issue: dashboard, env/freebsd-amd64: drop support for FreeBSD 9.3 builder

@gopherbot
Copy link

Change https://golang.org/cl/64910 mentions this issue: all: drop support for FreeBSD 9 or below

@mikioh
Copy link
Contributor Author

mikioh commented Sep 20, 2017 •
edited

Note that CL 64910 doesn't contain any stuff related to CLOCK_MONOTONIC, because I'm not convinced of the use of CLOCK_MONOTONIC_FAST in runtime; I mean fast vs. good.

Please open a new issue if you need the use of CLOCK_MONOTONIC_FAST on BSD variants.

@golang golang locked and limited conversation to collaborators Nov 28, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
FrozenDueToAge OS-FreeBSD
Projects
None yet
Milestone
Go1.10
Development

No branches or pull requests
3 participants
@bradfitz @mikioh @gopherbot