Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

x/net/{icmp,ipv4,ipv6}: replumbing in the net and internal/poll packages of go1.9 #19051

Closed
mikioh opened this issue Feb 13, 2017 · 12 comments
Closed
Milestone

Comments

@mikioh
Copy link
Contributor

mikioh commented Feb 13, 2017

Looks like the go team has decided to apply https://go-review.googlesource.com/c/36799/, which would break a few x/net packages that depend on unexposed fields of some types in the net package by using runtime reflection. Note that at the point of go1.1, there was no other good way to make an unexposed linkage between standard library and x/net packages.

This issue is just a reminder to keep x/net packages work with go1.6 or 1.7 through tip. Making the linkage more clean and stable makes sense, but it shouldn't break the existing API and make new exposed API.

@mikioh mikioh added this to the Unreleased milestone Feb 13, 2017
@gopherbot
Copy link

CL https://golang.org/cl/37034 mentions this issue.

gopherbot pushed a commit to golang/net that referenced this issue Feb 15, 2017
This package doesn't work with Go 1.9 or above.
The bypass surgery for grafting the net and internal/poll packages of
Go 1.9 starts with disabling this packge.

Updates golang/go#19051.

Change-Id: I82d742d267f155cf440884e845b24402a5a5bfdf
Reviewed-on: https://go-review.googlesource.com/37034
Reviewed-by: Ian Lance Taylor <iant@golang.org>
@gopherbot
Copy link

CL https://golang.org/cl/37038 mentions this issue.

@gopherbot
Copy link

CL https://golang.org/cl/37037 mentions this issue.

@gopherbot
Copy link

CL https://golang.org/cl/37039 mentions this issue.

@gopherbot
Copy link

CL https://golang.org/cl/37035 mentions this issue.

@gopherbot
Copy link

CL https://golang.org/cl/37036 mentions this issue.

@gopherbot
Copy link

CL https://golang.org/cl/37042 mentions this issue.

@gopherbot
Copy link

CL https://golang.org/cl/37401 mentions this issue.

gopherbot pushed a commit to golang/net that referenced this issue Feb 23, 2017
The x/net package is currently broken for Go 1.9 (#19051) so
I am unable to use trybots for x/net/http2.

This disables the tests for the broken stuff and makes things compile
at least, so x/net trybots aren't broken for others.

Updates golang/go#19051

Change-Id: I67401d7ad32d855e99a417545328eb4e803287cc
Reviewed-on: https://go-review.googlesource.com/37401
Run-TryBot: Brad Fitzpatrick <bradfitz@golang.org>
TryBot-Result: Gobot Gobot <gobot@golang.org>
Reviewed-by: Matt Layher <mdlayher@gmail.com>
Reviewed-by: Martin Möhrmann <moehrmann@google.com>
@gopherbot
Copy link

CL https://golang.org/cl/37472 mentions this issue.

@gopherbot
Copy link

CL https://golang.org/cl/37815 mentions this issue.

@gopherbot
Copy link

CL https://golang.org/cl/38277 mentions this issue.

@mikioh mikioh modified the milestones: Go1.9, Unreleased Apr 25, 2017
gopherbot pushed a commit that referenced this issue May 19, 2017
This change makes {TCP,UDP,IP,Unix}Conn types compliant of
syscall.Conn interface and adds type rawConn as an implementation of
syscall.RawConn interface.

By this change, the long-standing issues regarding unsupported socket
options and system calls can be solved partly and the broken x/net
packages due to https://go-review.googlesource.com/36799 can be
repaired.

Fixes #3661.
Updates #9661.
Updates #19051.
Updates #19435.

Change-Id: Ic996b040418b54f6d043bc70591789d5a5b23270
Reviewed-on: https://go-review.googlesource.com/37039
Run-TryBot: Mikio Hara <mikioh.mikioh@gmail.com>
TryBot-Result: Gobot Gobot <gobot@golang.org>
Reviewed-by: Ian Lance Taylor <iant@golang.org>
gopherbot pushed a commit to golang/net that referenced this issue May 24, 2017
This is a counterpart of https://go-review.googlesource.com/37039.

This change introduces a package that provides a portable interface
for the manipulation of sockets using either syscall.Conn and
syscall.RawConn interfaces or the internal/netreflect package
appropriately.

The package ensures that a package using this works with all supported
versions of the Go standard library.

Updates golang/go#19051.

Change-Id: Ib72ea369e6839e77fed6e35b9aedc364e73c51cb
Reviewed-on: https://go-review.googlesource.com/37035
Reviewed-by: Ian Lance Taylor <iant@golang.org>
gopherbot pushed a commit to golang/net that referenced this issue May 24, 2017
…t package

This change uses the internal/socket package to ensure that the ipv6
package works with all supported versions of the Go standard library.

Fixes golang/go#19051.

Change-Id: I74911a8c5bba79e082a10d64e621ed415be1c033
Reviewed-on: https://go-review.googlesource.com/37042
Reviewed-by: Ian Lance Taylor <iant@golang.org>
gopherbot pushed a commit to golang/net that referenced this issue May 24, 2017
Updates golang/go#19051.

Change-Id: I4d86de8ea3fb03e40dd50bc0351562fbfa2c46a7
Reviewed-on: https://go-review.googlesource.com/38277
Reviewed-by: Ian Lance Taylor <iant@golang.org>
@gopherbot
Copy link

CL https://golang.org/cl/37417 mentions this issue.

gopherbot pushed a commit to golang/net that referenced this issue May 24, 2017
This reverts https://go-review.googlesource.com/c/37401

Updates golang/go#19051.

Change-Id: Ia3cbc42213e3c519f91650e6308a7ca1f56b6189
Reviewed-on: https://go-review.googlesource.com/37417
Reviewed-by: Ian Lance Taylor <iant@golang.org>
@golang golang locked and limited conversation to collaborators May 24, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

2 participants