Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

x/mobile: TestObjcSeqBench broken by 34643, simple fix #19048

Closed
8tt opened this issue Feb 12, 2017 · 2 comments
Closed

x/mobile: TestObjcSeqBench broken by 34643, simple fix #19048

8tt opened this issue Feb 12, 2017 · 2 comments
Labels
FrozenDueToAge

Comments

@8tt
Copy link

8tt commented Feb 12, 2017 •
edited

The TestObjcSeqBench test that is using SeqBench.m assumes that default name prefix is Go, but it was changed to empty in the following commit:

bind: make the default name prefix empty on ObjC
https://go-review.googlesource.com/#/c/34643/

go test golang.org/x/mobile/bind/objc -run TestObjcSeqBench

failed

Possible fix:
in SeqBench.m replace GoBench prefix with Bench, or allow passing prefix to test run

go version go1.7.4 darwin/amd64
gomobile version +60b0aaa Tue Jan 31 20:25:16 2017 +0000 (android,ios); androidSDK=
@gopherbot
Copy link

CL https://golang.org/cl/37199 mentions this issue.

@gopherbot
Copy link

CL https://golang.org/cl/37314 mentions this issue.

@golang golang locked and limited conversation to collaborators Feb 21, 2018
imWildCat pushed a commit to imWildCat/go-mobile that referenced this issue Apr 10, 2021
bind/objc: fix benchmark
d2672ed 
The generator recently changed the default ObjC prefix to the empty
string but the benchmark wasn't changed accordingly (the benchmark
doesn't run in -short mode).

Fixes golang/go#19048

Change-Id: Id8f63da787f399410ea86c13ee77eb3005d31f38
Reviewed-on: https://go-review.googlesource.com/37314
Reviewed-by: Andris Valums <eighttt@fastmail.com>
Reviewed-by: Hyang-Ah Hana Kim <hyangah@gmail.com>
imWildCat pushed a commit to imWildCat/go-mobile that referenced this issue Apr 11, 2021
bind/objc: fix benchmark
6adcb2f 
The generator recently changed the default ObjC prefix to the empty
string but the benchmark wasn't changed accordingly (the benchmark
doesn't run in -short mode).

Fixes golang/go#19048

Change-Id: Id8f63da787f399410ea86c13ee77eb3005d31f38
Reviewed-on: https://go-review.googlesource.com/37314
Reviewed-by: Andris Valums <eighttt@fastmail.com>
Reviewed-by: Hyang-Ah Hana Kim <hyangah@gmail.com>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
FrozenDueToAge
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@gopherbot @8tt