Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: TestQueryContext flake on linux-amd64-race #19041

Closed
josharian opened this issue Feb 11, 2017 · 3 comments
Closed

build: TestQueryContext flake on linux-amd64-race #19041

josharian opened this issue Feb 11, 2017 · 3 comments
Milestone

Comments

@josharian
Copy link
Contributor

https://storage.googleapis.com/go-build-log/588411a7/linux-amd64-race_a24d74de.log

cc @kardianos

@josharian josharian added this to the Go1.9 milestone Feb 11, 2017
@bradfitz
Copy link
Contributor

@kardianos, dup of #19024? But https://go-review.googlesource.com/c/36794/ doesn't skip this one.

@gopherbot
Copy link

CL https://golang.org/cl/36902 mentions this issue.

@gopherbot
Copy link

CL https://golang.org/cl/36917 mentions this issue.

gopherbot pushed a commit that referenced this issue Feb 13, 2017
…t waits with checks

When testing context cancelation behavior do not rely on context
timeouts. Use explicit checks in all such tests. In closeDB
convert the simple check for zero open conns with a wait loop
for zero open conns.

Fixes #19024
Fixes #19041

Change-Id: Iecfcc4467e91249fceb21ffd1f7c62c58140d8e9
Reviewed-on: https://go-review.googlesource.com/36902
Run-TryBot: Daniel Theophanes <kardianos@gmail.com>
TryBot-Result: Gobot Gobot <gobot@golang.org>
Reviewed-by: Russ Cox <rsc@golang.org>
Reviewed-on: https://go-review.googlesource.com/36917
Run-TryBot: Brad Fitzpatrick <bradfitz@golang.org>
Reviewed-by: Daniel Theophanes <kardianos@gmail.com>
@golang golang locked and limited conversation to collaborators Feb 13, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

4 participants