Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

crypto/aes: unrecognized instruction "VORL" in ppc64le build #19014

Closed
laboger opened this issue Feb 9, 2017 · 1 comment
Closed

crypto/aes: unrecognized instruction "VORL" in ppc64le build #19014

laboger opened this issue Feb 9, 2017 · 1 comment

Comments

@laboger
Copy link
Contributor

laboger commented Feb 9, 2017

Please answer these questions before submitting your issue. Thanks!

What version of Go are you using (go version)?

tip

What operating system and processor architecture are you using (go env)?

any

Build failure for ppc64le due to a change to add asm implementation for crypto/aes. A recent opcode change was made in asm9.go to change VORL to VOR but the aes asm was still using VORL. The problem was not detected by running the trybot before merging.

In any case, VORL was recently changed to VOR, so the asm code just needs to make that change.

@gopherbot
Copy link

CL https://golang.org/cl/36625 mentions this issue.

ceseo pushed a commit to powertechpreview/go that referenced this issue May 17, 2017
Recently, a commit (85ecc51) changed the instruction from VORL to VOR.

Fixes golang#19014

Change-Id: I9a7e0b5771842b1abb5afc73dc41d5e7960cf390
Reviewed-on: https://go-review.googlesource.com/36625
TryBot-Result: Gobot Gobot <gobot@golang.org>
Reviewed-by: Brad Fitzpatrick <bradfitz@golang.org>
@golang golang locked and limited conversation to collaborators Feb 9, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

2 participants