Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

net/rpc: server_test fails if run with multiple values for -cpu #19001

Closed
bcmills opened this issue Feb 9, 2017 · 1 comment
Closed

net/rpc: server_test fails if run with multiple values for -cpu #19001

bcmills opened this issue Feb 9, 2017 · 1 comment
Labels
FrozenDueToAge

Comments

@bcmills
Copy link
Contributor

bcmills commented Feb 9, 2017

TestAcceptExitAfterListenerClose overwrites the global variables newServer and newServerAddr, which are guarded by a sync.Once and initialized in TestRPC.

This causes TestRPC to fail if it runs before TestAcceptExitAfterListenerClose and again after, which happens to be the case if you pass, say, -cpu=1,6 to the go test command.
@gopherbot
Copy link

CL https://golang.org/cl/36624 mentions this issue.

@golang golang locked and limited conversation to collaborators Feb 9, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
FrozenDueToAge
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@bcmills @gopherbot