Skip to content

cmd/gofmt: "a && b != 2" doesn't match "x != 1 && x != 2" #18987

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
mdempsky opened this issue Feb 7, 2017 · 2 comments
Closed

cmd/gofmt: "a && b != 2" doesn't match "x != 1 && x != 2" #18987

mdempsky opened this issue Feb 7, 2017 · 2 comments
Labels
FrozenDueToAge
Milestone
Go1.9

Comments

@mdempsky
Copy link
Contributor

mdempsky commented Feb 7, 2017

I would expect "a && b != 2" to match against "x != 1 && x != 2", but it doesn't:

$ cat /tmp/blah.go
package p

func f(x int) bool {
	return x != 1 && x != 2
}

$ gofmt -r 'a && b != 2 -> a' /tmp/blah.go
package p

func f(x int) bool {
	return x != 1 && x != 2
}
@mdempsky mdempsky added this to the Go1.9 milestone Feb 7, 2017
@mdempsky
Copy link
Contributor Author

mdempsky commented Feb 7, 2017

/cc @griesemer

@gopherbot
Copy link
Contributor

CL https://golang.org/cl/36546 mentions this issue.

@golang golang locked and limited conversation to collaborators Feb 8, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
FrozenDueToAge
Projects
None yet
Milestone
Go1.9
Development

No branches or pull requests
2 participants
@mdempsky @gopherbot