Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cmd/compile: speed up TestAssembly #18966

Closed
josharian opened this issue Feb 6, 2017 · 3 comments
Closed

cmd/compile: speed up TestAssembly #18966

josharian opened this issue Feb 6, 2017 · 3 comments
Labels
FrozenDueToAge Suggested Issues that may be good for new contributors looking for work to do.
Milestone

Comments

@josharian
Copy link
Contributor

TestAssembly is very slow, leading to it being skipped by default. This is not surprising--it separately invokes the compiler and parses the result many times. However, with some care, it should be possible to take all the test functions (all named func f), rename them, assemble a single file to compile out of it, and parse the results, correlating them back to the original. This should speed it up considerably.

No special knowledge of the compiler required, but will require some careful attention and thought. Might be good first hacking project for a patient person with Go experience who wants to see the awful guts of the toolchain in action. :)

@josharian josharian added the Suggested Issues that may be good for new contributors looking for work to do. label Feb 6, 2017
@josharian josharian added this to the Unplanned milestone Feb 6, 2017
@TocarIP
Copy link
Contributor

TocarIP commented Feb 7, 2017

Great idea! This will allow to avoid stuff like 6317f92f#commitcomment-20779055 in the future

@rugginoso
Copy link
Contributor

I'm working on this, just the time to clean-up the code and figure out how to submit the patch.

@gopherbot
Copy link

CL https://golang.org/cl/37270 mentions this issue.

@golang golang locked and limited conversation to collaborators Feb 24, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
FrozenDueToAge Suggested Issues that may be good for new contributors looking for work to do.
Projects
None yet
Development

No branches or pull requests

4 participants