Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

crypto/x509: docs for CreateCertificate omit template.AuthorityKeyId yet it is used in code #18962

Closed
taylortrimble opened this issue Feb 6, 2017 · 3 comments

Comments

@taylortrimble
Copy link

Documentation for crypto/x509.CreateCertficiate on the current golang.org page enumerates a list of fields from the certificate template that are considered when creating a certificate.

It omits the AuthorityKeyId field, but the source for buildExtensions, called by CreateCertificate, implies otherwise.

I would expect AuthorityKeyId to be added to the list of fields mentioned above in the documentation.

@odeke-em odeke-em changed the title Documentation for CreateCertificate forgets to include AuthorityKeyId crypto/x509: docs for CreateCertificate omit template.AuthorityKeyId yet it is used in code Feb 6, 2017
@odeke-em
Copy link
Member

odeke-em commented Feb 6, 2017

/cc @agl

@odeke-em odeke-em added this to the Go1.9 milestone Feb 6, 2017
@gopherbot
Copy link

CL https://golang.org/cl/36556 mentions this issue.

@taylortrimble
Copy link
Author

Thank you @agl!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

4 participants