Skip to content

x/build/devapp: frequent rate limiting #18934

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
kevinburke opened this issue Feb 4, 2017 · 4 comments
Closed

x/build/devapp: frequent rate limiting #18934

kevinburke opened this issue Feb 4, 2017 · 4 comments
Labels
Builders x/build issues (builders, bots, dashboards) FrozenDueToAge NeedsFix The path to resolution is known, but the work has not been done.
Milestone
Unreleased

Comments

@kevinburke
Copy link
Contributor

When running the server outside of an App Engine context, all issues have to be fetched into RAM when the server starts, usually by hitting the /update endpoint.

Frequently this yields 403 errors from Github and the following message:

GET https://api.github.com/repos/golang/go/issues/9669/events?page=1&per_page=100: 403 You have triggered an abuse detection mechanism. Please wait a few minutes before you try again. []

We should sleep and retry in these cases.
@bradfitz bradfitz added the Builders x/build issues (builders, bots, dashboards) label Feb 4, 2017
@bradfitz bradfitz self-assigned this Feb 4, 2017
@quentinmit
Copy link
Contributor

Or just cache the data on disk somewhere so you don't need to refetch everything.

@quentinmit
Copy link
Contributor

(To clarify, their rate limit resets once/hour, so sleeping and retrying is not very effective)

@kevinburke
Copy link
Contributor Author

@bradfitz thoughts? IIRC you were against a disk cache before; happy to add one or implement any other solution.

@bradfitz bradfitz added the NeedsFix The path to resolution is known, but the work has not been done. label Feb 5, 2017
@quentinmit quentinmit added this to the Unreleased milestone Feb 27, 2017
@bradfitz
Copy link
Contributor

devapp no longer uses GitHub API calls (as of golang/build@6990c34 in July 2017) so we can close this.

/cc @andybons @dmitshur

@golang golang locked and limited conversation to collaborators May 28, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
Builders x/build issues (builders, bots, dashboards) FrozenDueToAge NeedsFix The path to resolution is known, but the work has not been done.
Projects
None yet
Milestone
Unreleased
Development

No branches or pull requests
4 participants
@bradfitz @quentinmit @kevinburke @gopherbot