Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

crypto/x509: documentation for CreateCertificateRequest extensions unclear #18899

Closed
lwithers opened this issue Feb 2, 2017 · 1 comment
Closed

crypto/x509: documentation for CreateCertificateRequest extensions unclear #18899

lwithers opened this issue Feb 2, 2017 · 1 comment
Labels
Documentation FrozenDueToAge
Milestone
Go1.9

Comments

@lwithers
Copy link

lwithers commented Feb 2, 2017

In the documentation for the function x509.CreateCertificateRequest, the text states:

The following members of template are used: Subject, Attributes, SignatureAlgorithm, Extensions, DNSNames, EmailAddresses, and IPAddresses.

This implies that we read the CertificateRequest.Extensions field when creating the CSR, and that this would be the correct slice into which we place desired X509v3 extensions; however, this is inaccurate, since we actually only read the .ExtraExtensions field. The documentation should be altered to reflect this.
@bradfitz bradfitz added this to the Go1.9 milestone Feb 2, 2017
@gopherbot
Copy link

CL https://golang.org/cl/36558 mentions this issue.

@golang golang locked and limited conversation to collaborators Feb 9, 2018
@rsc rsc unassigned agl Jun 23, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
Documentation FrozenDueToAge
Projects
None yet
Milestone
Go1.9
Development

No branches or pull requests
4 participants
@bradfitz @agl @gopherbot @lwithers