Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

testing: -timeout affects benchmarks too (regression) #18845

Closed
evverx opened this issue Jan 29, 2017 · 3 comments
Closed

testing: -timeout affects benchmarks too (regression) #18845

evverx opened this issue Jan 29, 2017 · 3 comments
Labels
FrozenDueToAge NeedsFix The path to resolution is known, but the work has not been done.
Milestone
Go1.8Maybe

Comments

@evverx
Copy link

evverx commented Jan 29, 2017

This regression was introduced in ead08e9#diff-70e628298261565d825f7199d13042f2L758

package bench

import (
        "testing"
        "time"
)

func BenchmarkSleep10(b *testing.B) {
        time.Sleep(10 * time.Second)
}
go test -v -bench=. -timeout=1s
  • go version go1.7.5 linux/amd64
BenchmarkSleep10-2             1        10000282918 ns/op
PASS
  • go version devel +6bdb0c1 Sun Jan 29 00:49:56 2017 +0000 linux/amd64
panic: test timed out after 1s
@ALTree
Copy link
Member

ALTree commented Jan 29, 2017

Looks like stopAlarm() was removed by rsc between patch set 4 and 5, but in the CL discussion I see nothing that can explain why.

I've cooked up a quick patch and in theory just adding back a stopAlarm() call after runExamples() should fix the problem, but I'm not confident I'm not missing something.

@ALTree ALTree added the NeedsFix The path to resolution is known, but the work has not been done. label Jan 29, 2017
@gopherbot
Copy link

CL https://golang.org/cl/35956 mentions this issue.

@ianlancetaylor ianlancetaylor added this to the Go1.8Maybe milestone Jan 30, 2017
@ianlancetaylor ianlancetaylor mentioned this issue Jan 31, 2017
Closed
@gopherbot
Copy link

CL https://golang.org/cl/36125 mentions this issue.

gopherbot pushed a commit that referenced this issue Feb 2, 2017
@ALTree @bradfitz
[release-branch.go1.8] testing: stop timeout-timer after running tests
4707045 
Fixes #18845

Fixes #18870 (Go 1.8 backport)

Change-Id: Icdc3e2067807781e42f2ffc94d1824aed94d3713
Reviewed-on: https://go-review.googlesource.com/35956
Run-TryBot: Alberto Donizetti <alb.donizetti@gmail.com>
TryBot-Result: Gobot Gobot <gobot@golang.org>
Reviewed-by: Ian Lance Taylor <iant@golang.org>
(cherry picked from commit 7d8bfdd)
Reviewed-on: https://go-review.googlesource.com/36125
@golang golang locked and limited conversation to collaborators Feb 2, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
FrozenDueToAge NeedsFix The path to resolution is known, but the work has not been done.
Projects
None yet
Milestone
Go1.8Maybe
Development

No branches or pull requests
4 participants
@ianlancetaylor @ALTree @gopherbot @evverx