Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

net/http/httputil: ReverseProxy read error during body copy: context canceled #18838

Closed
anacrolix opened this issue Jan 29, 2017 · 3 comments
Closed

net/http/httputil: ReverseProxy read error during body copy: context canceled #18838

anacrolix opened this issue Jan 29, 2017 · 3 comments
Labels
FrozenDueToAge
Milestone
Go1.9

Comments

@anacrolix
Copy link
Contributor

I get a lot of this error

reverseproxy.go:316: httputil: ReverseProxy read error during body copy: context canceled

While using ReverseProxy. It's caused by the original request being closed, and it triggering the origin request to be closed. I suspect it's a frequent error message now that http.Request.Context is marked done when a client request goes away in Go1.8. I don't think it should be logged. I expect that httputil.ReverseProxy.copyBuffer can be modified to filter rerr==context.Canceled.
@odeke-em odeke-em changed the title httputil: ReverseProxy read error during body copy: context canceled net/http/httputil: ReverseProxy read error during body copy: context canceled Jan 29, 2017
@odeke-em
Copy link
Member

/cc @bradfitz

@dsnet
Copy link
Member

dsnet commented Jan 29, 2017

(Ignore my prior comment - now deleted. I misread the post and see that you are only concerned about logging.)

@bradfitz bradfitz added this to the Go1.9 milestone Feb 1, 2017
@Sajmani Sajmani self-assigned this Feb 6, 2017
@gopherbot
Copy link

CL https://golang.org/cl/36358 mentions this issue.

@aronatkins aronatkins mentioned this issue Apr 24, 2017
Open
@golang golang locked and limited conversation to collaborators Feb 6, 2018
@rsc rsc unassigned Sajmani Jun 23, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
FrozenDueToAge
Projects
None yet
Milestone
Go1.9
Development

No branches or pull requests
6 participants
@bradfitz @anacrolix @odeke-em @dsnet @gopherbot @Sajmani