Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cmd/go: go test -buildmode=plugin #18814

Closed
crawshaw opened this issue Jan 27, 2017 · 3 comments
Closed

cmd/go: go test -buildmode=plugin #18814

crawshaw opened this issue Jan 27, 2017 · 3 comments
Labels
Builders x/build issues (builders, bots, dashboards) GoCommand cmd/go Proposal WaitingForInfo Issue is not actionable because of missing required information, which needs to be provided.
Milestone
Unplanned

Comments

@crawshaw
Copy link
Member

Over on #18729 I am finding bugs by taking existing package unit tests and converting them into plugins that shell unit test can then call.

This is a bit messy to do outside of the go tool, as it requires messing with the definition of a package (including export_test.go, exporting the test functions, etc). It would be relatively straightforward to do inside the go tool, and we already have the flags we would need to trigger it.

Then we could have a builder that runs all the tests under plugins, which would exercise the multi-module code paths in the runtime package used by -buildmode=shared and -buildmode=plugin.
@crawshaw crawshaw added this to the Go1.9 milestone Jan 27, 2017
@crawshaw crawshaw self-assigned this Jan 27, 2017
@crawshaw crawshaw mentioned this issue Jan 30, 2017
Closed
@bradfitz bradfitz added the Builders x/build issues (builders, bots, dashboards) label Jan 30, 2017
@bradfitz bradfitz modified the milestones: Go1.9, Go1.10 Jun 7, 2017
@rsc rsc modified the milestones: Go1.10, Unplanned Dec 1, 2017
@cespare cespare mentioned this issue Aug 20, 2021
Closed
@cespare
Copy link
Contributor

cespare commented Aug 24, 2021

Here's an example where I'd love to be able to just run go test -buildmode=plugin to run all my normal tests with dynamic linking: cespare/xxhash@3b9a658. Instead, I settled for just running a few cursory tests through a plugin that my test compiles.

@bcmills bcmills added the GoCommand cmd/go label Sep 7, 2023
@bcmills
Copy link
Contributor

bcmills commented Sep 7, 2023

If someone wants to move this forward, I think it would be useful to have a concrete description of what -buildmode=plugin would mean and what it would do. Specifically, what would the main package for the test binary look like?

@bcmills bcmills added the WaitingForInfo Issue is not actionable because of missing required information, which needs to be provided. label Sep 7, 2023
@gopherbot
Copy link

Timed out in state WaitingForInfo. Closing.

(I am just a bot, though. Please speak up if this is a mistake or you have the requested information.)

@gopherbot gopherbot closed this as not planned Won't fix, can't repro, duplicate, stale Oct 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Builders x/build issues (builders, bots, dashboards) GoCommand cmd/go Proposal WaitingForInfo Issue is not actionable because of missing required information, which needs to be provided.
Projects
Proposals
Status: Incoming
Milestone
Unplanned
Development

No branches or pull requests
6 participants
@bradfitz @rsc @crawshaw @cespare @bcmills @gopherbot