Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

net/http: test panic on linux-386 #18801

Closed
broady opened this issue Jan 26, 2017 · 3 comments
Closed

net/http: test panic on linux-386 #18801

broady opened this issue Jan 26, 2017 · 3 comments
Labels
FrozenDueToAge release-blocker Testing An issue that has been verified to require only test changes, not just a test failure.
Milestone
Go1.10

Comments

@broady
Copy link
Member

broady commented Jan 26, 2017

While cutting 1.7.5:

panic: Fail in goroutine after TestIdleConnH2Crash has completed

goroutine 6665 [running]:
panic(0x83f0620, 0x18ae4330)
        /tmp/workdir/go/src/runtime/panic.go:500 +0x331
testing.(*common).Fail(0x18e30300)
        /tmp/workdir/go/src/testing/testing.go:412 +0x10d
testing.(*common).Error(0x18e30300, 0x1894ac14, 0x1, 0x1)
        /tmp/workdir/go/src/testing/testing.go:478 +0x61
net/http_test.TestIdleConnH2Crash.func2(0x84460d3, 0x3, 0x18c513c8, 0xf, 0x0, 0x0, 0x0, 0x0)
        /tmp/workdir/go/src/net/http/transport_test.go:3545 +0x1d9
net/http.(*Transport).dialConn(0x18b140a0, 0x85d8680, 0x18c51460, 0x0, 0x18c513c0, 0x5, 0x18c513c8, 0xf, 0x0, 0x0, ...)
        /tmp/workdir/go/src/net/http/transport.go:949 +0x3c5
net/http.(*Transport).getConn.func4(0x18b140a0, 0x85d8680, 0x18c51460, 0x18c514a0, 0x18b4a500)
        /tmp/workdir/go/src/net/http/transport.go:885 +0x48
created by net/http.(*Transport).getConn
        /tmp/workdir/go/src/net/http/transport.go:887 +0x3a0
FAIL    net/http        16.102s
@broady broady added this to the Unreleased milestone Jan 26, 2017
@bradfitz bradfitz modified the milestones: Go1.9, Unreleased Jan 26, 2017
@bradfitz bradfitz added the Testing An issue that has been verified to require only test changes, not just a test failure. label Jan 26, 2017
@bradfitz
Copy link
Contributor

Yeah, test looks like it could use work. It's also full of typos. Will fix, thanks.

@ianlancetaylor
Copy link
Contributor

Just saw this failure on OpenBSD:

--- FAIL: TestIdleConnH2Crash (0.06s)
	transport_test.go:3742: write tcp 127.0.0.1:42762->127.0.0.1:4536: write: socket is not connected
FAIL
FAIL	net/http	5.203s

https://storage.googleapis.com/go-build-log/b809bbbc/openbsd-amd64-60_156a748f.log

@broady broady modified the milestones: Go1.9Maybe, Go1.9 Jul 17, 2017
@ianlancetaylor ianlancetaylor modified the milestones: Go1.10, Go1.9Maybe Aug 3, 2017
@rsc
Copy link
Contributor

rsc commented Nov 22, 2017

Timed out.

@rsc rsc closed this as completed Nov 22, 2017
@golang golang locked and limited conversation to collaborators Nov 22, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
FrozenDueToAge release-blocker Testing An issue that has been verified to require only test changes, not just a test failure.
Projects
None yet
Milestone
Go1.10
Development

No branches or pull requests
5 participants
@bradfitz @broady @rsc @ianlancetaylor @gopherbot