Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

mime/multipart: SetBoundary should allow length <= 70, not <=69 #18793

Closed
skinp opened this issue Jan 26, 2017 · 1 comment
Closed

mime/multipart: SetBoundary should allow length <= 70, not <=69 #18793

skinp opened this issue Jan 26, 2017 · 1 comment
Labels
FrozenDueToAge NeedsFix The path to resolution is known, but the work has not been done.
Milestone
Go1.9

Comments

@skinp
Copy link
Contributor

skinp commented Jan 26, 2017

What version of Go are you using (go version)?

go version go1.7.3 darwin/amd64

What operating system and processor architecture are you using (go env)?

GOARCH="amd64"
GOBIN=""
GOEXE=""
GOHOSTARCH="amd64"
GOHOSTOS="darwin"
GOOS="darwin"
GOPATH="/Users/patp/code/go"
GORACE=""
GOROOT="/usr/local/Cellar/go/1.7.3/libexec"
GOTOOLDIR="/usr/local/Cellar/go/1.7.3/libexec/pkg/tool/darwin_amd64"
CC="clang"
GOGCCFLAGS="-fPIC -m64 -pthread -fno-caret-diagnostics -Qunused-arguments -fmessage-length=0 -fdebug-prefix-map=/var/folders/lx/52t0qc4n669_8vp0q3x8r_6rgmmb82/T/go-build977737223=/tmp/go-build -gno-record-gcc-switches -fno-common"
CXX="clang++"
CGO_ENABLED="1"

What did you do?

While looking at RFC 2046, section 5.1.1 following up #18768, I saw Go's mime/multipart only allowed SetBoundary with string length <= 69 while the RFC specifies <= 70.

Playground repro: https://play.golang.org/p/Dk64NzUbb7

What did you expect to see?

Expected a Boundary of length 70 to not error...

What did you see instead?

2009/11/10 23:00:00 Failed to set boundary: mime: invalid boundary length
@bradfitz bradfitz added this to the Go1.9 milestone Jan 26, 2017
@bradfitz bradfitz added the NeedsFix The path to resolution is known, but the work has not been done. label Jan 26, 2017
@gopherbot
Copy link

CL https://golang.org/cl/35830 mentions this issue.

@golang golang locked and limited conversation to collaborators Feb 1, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
FrozenDueToAge NeedsFix The path to resolution is known, but the work has not been done.
Projects
None yet
Milestone
Go1.9
Development

No branches or pull requests
3 participants
@bradfitz @skinp @gopherbot