Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

testing: document MainStart signature change in release notes #18766

Closed
bradfitz opened this issue Jan 23, 2017 · 0 comments
Closed

testing: document MainStart signature change in release notes #18766

bradfitz opened this issue Jan 23, 2017 · 0 comments
Labels
Documentation FrozenDueToAge NeedsFix The path to resolution is known, but the work has not been done.
Milestone
Go1.8

Comments

@bradfitz
Copy link
Contributor

c56cc9b (https://golang.org/cl/32455) changed the signature of testing.MainStart

from:
https://golang.org/pkg/testing/#MainStart

func MainStart(matchString func(pat, str string) (bool, error), tests []InternalTest, benchmarks []InternalBenchmark, examples []InternalExample) *M

To:
https://beta.golang.org/pkg/testing/#MainStart

func MainStart(deps testDeps, tests []InternalTest, benchmarks []InternalBenchmark, examples []InternalExample) *M

This is not in our release notes, and just bit Kubernetes in kubernetes/kubernetes#38926 (comment)

For the record, this does say:

It is not meant to be called directly and is not subject to the Go 1 compatibility document. It may change signature from release to release.

/cc @rsc
@bradfitz bradfitz added Documentation NeedsFix The path to resolution is known, but the work has not been done. labels Jan 23, 2017
@bradfitz bradfitz added this to the Go1.8 milestone Jan 23, 2017
@bradfitz bradfitz mentioned this issue Jan 23, 2017
Merged
@bradfitz bradfitz changed the title testing: document TestMain signature change in release notes testing: document MainStart signature change in release notes Jan 23, 2017
@golang golang locked and limited conversation to collaborators Jan 24, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
Documentation FrozenDueToAge NeedsFix The path to resolution is known, but the work has not been done.
Projects
None yet
Milestone
Go1.8
Development

No branches or pull requests
2 participants
@bradfitz @gopherbot