Navigation Menu

Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

x/build/cmd/buildstats: Cannot compile project #18764

Closed
kevinburke opened this issue Jan 23, 2017 · 5 comments
Closed

x/build/cmd/buildstats: Cannot compile project #18764

kevinburke opened this issue Jan 23, 2017 · 5 comments
Labels
Builders x/build issues (builders, bots, dashboards) FrozenDueToAge NeedsFix The path to resolution is known, but the work has not been done.

Comments

@kevinburke
Copy link
Contributor

I'm getting the following error with the latest version of golang.org/x/build and the latest version of cloud.google.com/go/bigquery.

$ go build golang.org/x/build/cmd/buildstats
# golang.org/x/build/cmd/buildstats
cmd/buildstats/buildstats.go:63: undefined: "cloud.google.com/go/bigquery".ValueList

Searching through the bigquery codebase reveals a private valueList struct. It looks like it was unexported here: https://code-review.googlesource.com/#/c/9567/
@bradfitz
Copy link
Contributor

@jba, what should we do?

@kevinburke
Copy link
Contributor Author

Switching the ValueList in buildstats.go to a []*bigquery.Value yields the following compile error:

invalid type assertion: values[0].(time.Time) (non-interface type *"cloud.google.com/go/bigquery".Value on left)

though a Value is:

type Value interface{}

@jba
Copy link
Contributor

jba commented Jan 23, 2017

Should be a *[]bigquery.Value

@jba
Copy link
Contributor

jba commented Jan 23, 2017

I mean

var values []bigquery.Value
err = it.Next(&values)

@bradfitz
Copy link
Contributor

@kevinburke, can you try that?

@bradfitz bradfitz added Builders x/build issues (builders, bots, dashboards) NeedsFix The path to resolution is known, but the work has not been done. labels Jan 23, 2017
@golang golang locked and limited conversation to collaborators Jan 23, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
Builders x/build issues (builders, bots, dashboards) FrozenDueToAge NeedsFix The path to resolution is known, but the work has not been done.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@bradfitz @kevinburke @gopherbot @jba