Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cmd/go: "go test" accepts -test.FLAG where FLAG is any flag accepted by "go build" #18682

Closed
minux opened this issue Jan 17, 2017 · 4 comments
Closed
Labels
FrozenDueToAge NeedsFix The path to resolution is known, but the work has not been done.
Milestone

Comments

@minux
Copy link
Member

minux commented Jan 17, 2017

This behavior always existed from Go 1.0.

For example:

$ go test image -test.work
WORK=/tmp/go-build271188011
ok  	image	0.361s

Is this expected? I find it quite confusing as there is no -test.work flag documented anywhere and it conflicts with user defined -test.FLAG flags. If this is WAI, we probably should document it.

@bradfitz bradfitz added this to the Go1.9 milestone Jan 19, 2017
@rsc
Copy link
Contributor

rsc commented Jun 22, 2017

Yes, we should definitely fix this, but I think it's too late for Go 1.9.

@rsc rsc modified the milestones: Go1.10, Go1.9 Jun 22, 2017
@rsc rsc modified the milestones: Go1.10, Go1.11 Dec 1, 2017
@rsc
Copy link
Contributor

rsc commented Apr 18, 2018

/cc @bcmills

@gopherbot gopherbot modified the milestones: Go1.11, Unplanned May 23, 2018
@bcmills bcmills added the NeedsFix The path to resolution is known, but the work has not been done. label Jan 18, 2019
@bcmills bcmills self-assigned this Jan 22, 2020
@bcmills bcmills modified the milestones: Unplanned, Go1.15 Jan 22, 2020
@bcmills
Copy link
Contributor

bcmills commented Jan 22, 2020

I think CL 211358 will fix this.

@gopherbot
Copy link

Change https://golang.org/cl/211358 mentions this issue: cmd/go/internal/{test,vet}: use a standard flag.FlagSet to parse flags

@golang golang locked and limited conversation to collaborators Feb 24, 2021
@rsc rsc unassigned bcmills Jun 23, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
FrozenDueToAge NeedsFix The path to resolution is known, but the work has not been done.
Projects
None yet
Development

No branches or pull requests

5 participants