Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

x/crypto/poly1305: multiple definition of `poly1305Mask' #18673

Closed
mappu opened this issue Jan 16, 2017 · 5 comments
Closed

x/crypto/poly1305: multiple definition of `poly1305Mask' #18673

mappu opened this issue Jan 16, 2017 · 5 comments
Labels
FrozenDueToAge
Milestone
Go1.8Maybe

Comments

@mappu
Copy link

mappu commented Jan 16, 2017 •
edited

Hi, this bug report is for the x/crypto package, but the github doesn't have its dedicated issue tracker, so sorry if it's misplaced.

What version of Go are you using (go version)?

go version go1.8rc1 windows/amd64

What operating system and processor architecture are you using (go env)?

set GOARCH=amd64
set GOBIN=
set GOEXE=.exe
set GOHOSTARCH=amd64
set GOHOSTOS=windows
set GOOS=windows
set GOPATH=C:\Users\mappu\go
set GORACE=
set GOROOT=C:\Go
set GOTOOLDIR=C:\Go\pkg\tool\windows_amd64
set GCCGO=gccgo
set CC=gcc
set GOGCCFLAGS=-m64 -mthreads -fmessage-length=0 -fdebug-prefix-map=C:\cygwin\tmp\go-build713941879=/tmp/go-build -gno-record-gcc-switches
set CXX=g++
set CGO_ENABLED=1
set PKG_CONFIG=pkg-config
set CGO_CFLAGS=-g -O2
set CGO_CPPFLAGS=
set CGO_CXXFLAGS=-g -O2
set CGO_FFLAGS=-g -O2
set CGO_LDFLAGS=-g -O2

What did you do?

  1. Have a program that uses golang.org/x/crypto/poly1305 and also CGO
  2. Update from old commit e311231e83195f401421a286060d65643f9c9d40 to new commit 2f8be38b9a7533b8763d48273737ff6e90428a96
  3. Attempt to build using the updated library

What did you expect to see?

normal successful build

What did you see instead?

C:\Go\pkg\tool\windows_amd64\link.exe: running gcc failed: exit status 1
C:\cygwin\tmp\go-link-667453455\go.o:(.text+0x615bb0): multiple definition of `poly1305Mask'
C:\cygwin\tmp\go-link-667453455\go.o:(.text+0x615ba0): first defined here
collect2: error: ld returned 1 exit status

The build succeeds if i revert to the older x/crypto commit.
@bradfitz bradfitz added this to the Go1.8Maybe milestone Jan 16, 2017
@bradfitz
Copy link
Contributor

/cc @agl

@gopherbot
Copy link

CL https://golang.org/cl/35260 mentions this issue.

@gopherbot
Copy link

CL https://golang.org/cl/35259 mentions this issue.

gopherbot pushed a commit to golang/crypto that referenced this issue Jan 16, 2017
@minux
poly1305: make data declared in assembly files private
abc5fa7 
Update golang/go#18673.

Change-Id: I3ba89bab42f17e6fd7005df40c7a853aef1fda37
Reviewed-on: https://go-review.googlesource.com/35259
Run-TryBot: Minux Ma <minux@golang.org>
TryBot-Result: Gobot Gobot <gobot@golang.org>
Reviewed-by: Adam Langley <agl@golang.org>
@mappu
Copy link
Author

mappu commented Jan 16, 2017

I can confirm the updated commit abc5fa7 did fix the issue.

@minux minux mentioned this issue Jan 16, 2017
Open
@minux
Copy link
Member

minux commented Jan 16, 2017 via email

gopherbot pushed a commit that referenced this issue Jan 19, 2017
@broady
[release-branch.go1.8] all: merge master into release-branch.go1.8
d18087c 
6593d86 go/ast: fix Object's doc comment about Data
c1730ae runtime: force workers out before checking mark roots
d10eddc testing: make parallel t.Run safe again
2c8b70e crypto/x509: revert SystemCertPool implementation for Windows
fcfd918 doc/go1.8: document Plan 9 requirements
81a61a9 runtime: for plugins, don't add duplicate itabs
f674537 README.md: update and simplify
d871191 cmd/go: fix bug help message
48d8edb crypto/tls: disable CBC cipher suites with SHA-256 by default
92ecd78 cmd/compile: add ZeroWB case in writebarrier
787125a doc: 2017 is the Year of the Gopher
5b708a6 cmd/compile: lvalues are only required for == when calling runtime fns
e83d506 vendor/golang_org/x/crypto/poly1305: revendor to pick up fix for #18673
76f981c net/http: skip TestServerHijackGetsBackgroundByte on Plan 9
e395e32 net/http: skip TestServerHijackGetsBackgroundByte_big on Plan 9
6a3c6c0 net/http: add another hijack-after-background-read test
467109b all: test adjustments for the iOS builder
b2a3b54 net/http: make sure Hijack's bufio.Reader includes pre-read background byte
593ea3b cmd/go, misc: rework cwd handling for iOS tests
0642b8a syscall: export Fsid.X__val on s390x
4601eae doc/gdb: mention GOTRACEBACK=crash
4c4c5fc misc/cgo/testplugin: test that types and itabs are unique
22689c4 reflect: keep makeFuncImpl live across makeFuncStub
9cf06ed cmd/link: only exclude C-only symbols on darwin
9c3630f compress/flate: avoid large stack growth in fillDeflate
4f0aac5 cmd/go: add comment about SIGUSR2 on iOS
333f764 cmd/go, misc: switch from breakpoint to SIGUSR2
39e31d5 doc/go1.8: update timezone database version
08da820 misc/cgo/testshared: test that types and itabs are unique
fdde7ba runtime: avoid clobbering C callee-save register in cgoSigtramp
f65abf6 cmd/compile: hide testdclstack behind debug flag
641ef2a compress/gzip: skip TestGZIPFilesHaveZeroMTimes on non-builders
0724aa8 crypto/dsa: gofmt
ac05542 net/http: deflake TestRetryIdempotentRequestsOnError
b842c9a doc: remove inline styles

Change-Id: I642c056732fe1e8081e9d73e086e38ea0b2568cc
@golang golang locked and limited conversation to collaborators Oct 9, 2018
@rsc rsc unassigned agl Jun 23, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
FrozenDueToAge
Projects
None yet
Milestone
Go1.8Maybe
Development

No branches or pull requests
5 participants
@bradfitz @agl @minux @mappu @gopherbot