-
Notifications
You must be signed in to change notification settings - Fork 17.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
cmd/compile: rsc/compilebench -alloc is broken #18641
Comments
This appears to be because runtime/pprof switched to writing binary pprof files, so compilebench's code to parse the /cc @matloob |
Just hit this myself. Sadness. (I wonder whether anyone else was parsing the pprof output to get memstats and will also be impacted by this change.) I don't see an obvious way to add ignored to the binary pprof output, and I really don't want to embed a protobuf decoder in compilebench anyway. I propose instead that we add a
How does that sound? |
Perhaps we should add a GODEBUG variable to switch back to the old pprof
format?
|
I assume that at some point @matloob will want to eliminate the old code, but as an interim measure, that'd be really useful. Particularly if it could go in for 1.8--it is a tiny, safe change--but I'm not going to hold my breath for that. |
In general, I'd argue that changing file format should give the users at
least one release to migrate to new format, which means we should at least
release Go 1.8 to support both formats and also with the ability to switch
format at runtime (so that people using Go 1.8 compiled programs without
source code can still use tools that only works with the old format.)
I think we should address this before Go 1.8.
|
Can you prepare a non-scary CL before Monday? |
False alarm. While preparing a CL, I accidentally read the documentation (oops). CL on its way. |
gopherbot down? CL 35484 |
I think the problem remains, we can't change all programs to pass non-zero
debug argument to WriteTo.
|
But those who have the problem have a one line fix available. They'd have to do the same thing with a GODEBUG envvar. |
Using rsc/compilebench's -alloc flag, all compiles currently report "0 B/op 0 allocs/op". Presumably something in cmd/compile changed that broke this. We should either revert that change, or update rsc/compilebench accordingly.
The text was updated successfully, but these errors were encountered: