x/sys/unix: missing SYS_MSYNC for NetBSD #18513
Labels
FrozenDueToAge
OS-NetBSD
Suggested
Issues that may be good for new contributors looking for work to do.
Milestone
Comments
|
The Go syscall package is frozen. See https://golang.org/pkg/syscall/#pkg-overview We can repurpose this bug for the https://godoc.org/golang.org/x/sys/unix package, though. |
bradfitz
changed the title
bradfitz
added
OS-NetBSD
Suggested
|
On Thu, Jan 5, 2017 at 4:47 PM, Lion Yang ***@***.***> wrote:
BTW, I cannot access https://golang.org/s/go1.4-syscall (the URL in
https://golang.org/pkg/syscall/#pkg-overview).
I just checked, the URL redirects to the correct Google Docs fine.
$ curl -I https://golang.org/s/go1.4-syscall
HTTP/1.1 302 Found
Strict-Transport-Security: max-age=31536000; preload
Location:
https://docs.google.com/a/golang.org/document/d/1QXzI9I1pOfZPujQzxhyRy6EeHYTQitKKjHfpq0zpxZs/
Content-Type: text/html; charset=utf-8
Date: Thu, 05 Jan 2017 23:26:46 GMT
Server: Google Frontend
Alt-Svc: quic=":443"; ma=2592000; v="35,34"
Transfer-Encoding: chunked
|
|
@minix Yes you are right. I forgot to turn on my lovely local DNS, embarrassing... |
|
Change https://golang.org/cl/56172 mentions this issue: |
micanzhang
pushed a commit
to micanzhang/sys
that referenced
this issue
Sep 12, 2017
Make Madvice, Mlock, Mlockall, Mprotect, Msync, Munlock and Munlockall available equally on all BSD flavors. NetBSD was previously lacking SYS_MSYNC, so add it. Reorder the //sys function prototype alphabetically and clean up already implemented syscalls everywhere. Also add tests for Mprotect, Msync and Madvice - now that they're available on all unix platforms. Fixes golang/go#18513 Change-Id: I0eb502d72c7e991f191fb96225ef04e8297d8b8d Reviewed-on: https://go-review.googlesource.com/56172 Run-TryBot: Daniel Martí <mvdan@mvdan.cc> TryBot-Result: Gobot Gobot <gobot@golang.org> Reviewed-by: Daniel Martí <mvdan@mvdan.cc> Reviewed-by: Ian Lance Taylor <iant@golang.org>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Please answer these questions before submitting your issue. Thanks!
What version of Go are you using (
go version)?Problem exists on HEAD.
What operating system and processor architecture are you using (
go env)?Let's pretend I am using NetBSD.
What did you do?
A few days ago I somehow saw edsrdf's mmap-go, which self-defines an syscall number for
SYS_MSYNC(277) on NetBSD. Apparently Go's current syscall extraction fails to find it in NetBSD headers.For cross-check I looked at
syscalls.master, which also points to 277 as msync:What did you expect to see?
Proper
SYS_MSYNC.What did you see instead?
It doesn't exist.
The text was updated successfully, but these errors were encountered: