You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Every now and again a test isn't enabled on a platform where it should be (for example: 161cd34). A leading culprit of this is feature checks that only run a test if the GOOS/GOARCH combination is in a list:
pair:=t.gohostos+"-"+t.goarchswitch (pair) {
case"android-arm", "darwin-arm", ...:
// run testdefault:
// don't run test
}
If a GOOS/GOARCH combination isn't correctly added to one of the many lists like this, then the related tests simply won't run. This is not always obvious.
I think it would be good to refactor test.go so that it always defaults to running a test unless explicitly told not to for a given platform (preferably with an issue referencing the missing feature). This will make it harder to accidentally forget to enable a test.
The text was updated successfully, but these errors were encountered:
Every now and again a test isn't enabled on a platform where it should be (for example: 161cd34). A leading culprit of this is feature checks that only run a test if the GOOS/GOARCH combination is in a list:
If a GOOS/GOARCH combination isn't correctly added to one of the many lists like this, then the related tests simply won't run. This is not always obvious.
I think it would be good to refactor test.go so that it always defaults to running a test unless explicitly told not to for a given platform (preferably with an issue referencing the missing feature). This will make it harder to accidentally forget to enable a test.
The text was updated successfully, but these errors were encountered: