You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
The "fake" jump conditions as well as the LoadExtension instructions
are now disassembled correctly. Therefore the workaround to reassemble
the disassembly is no longer necessary.
This simplification was annonced already in golang/go#18470.
Result of `go test -cover .` stays the same with this simplification.
$ go test -cover golang.org/x/net/bpf
ok golang.org/x/net/bpf 0.495s coverage: 92.3% of statements
Change-Id: I3f9eb46148287c76059437b773b80c4c99eb5b53
Reviewed-on: https://go-review.googlesource.com/34951
Run-TryBot: Mikio Hara <mikioh.mikioh@gmail.com>
TryBot-Result: Gobot Gobot <gobot@golang.org>
Reviewed-by: Matt Layher <mdlayher@gmail.com>
What version of Go are you using (
go version
)?go version go1.7.4 linux/amd64
What operating system and processor architecture are you using (
go env
)?linux, amd64
What did you do?
Disassemble bpf conditional jump instructions:
jneq
(jne
),jlt
,jle
.What did you expect to see?
bpf.JumpIf
with conditionbpf.JumpNotEqual
,bpf.JumpLessThan
andbpf.JumpLessOrEqual
should disassemble to the same types again.What did you see instead?
Conditions are disassebled to
bpf.JumpEqual
,bpf.JumpGreaterOrEqual
andbpf.JumpGreaterThan
.Similar issue as: #18469
With both issues (this one and #18469) resolved, the test in https://github.com/golang/net/blob/master/bpf/instructions_test.go#L145-L184 could be simplified without the special handling for "fake" jump conditions.
The text was updated successfully, but these errors were encountered: