Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cmd/go: docs to make it more obvious how build tags are meant to be passed #18351

Closed
mrkane27 opened this issue Dec 16, 2016 · 2 comments
Closed

cmd/go: docs to make it more obvious how build tags are meant to be passed #18351

mrkane27 opened this issue Dec 16, 2016 · 2 comments
Labels
FrozenDueToAge NeedsDecision Feedback is required from experts, contributors, and/or the community before a change can be made.
Milestone
Go1.9

Comments

@mrkane27
Copy link

Please answer these questions before submitting your issue. Thanks!

What version of Go are you using (go version)?

go version go1.7.3 darwin/amd64

What operating system and processor architecture are you using (go env)?

GOARCH="amd64"
GOBIN=""
GOEXE=""
GOHOSTARCH="amd64"
GOHOSTOS="darwin"
GOOS="darwin"
GOPATH="/Volumes/dev/gpuroot"
GORACE=""
GOROOT="/usr/local/Cellar/go/1.7.3/libexec"
GOTOOLDIR="/usr/local/Cellar/go/1.7.3/libexec/pkg/tool/darwin_amd64"
CC="clang"
GOGCCFLAGS="-fPIC -m64 -pthread -fno-caret-diagnostics -Qunused-arguments -fmessage-length=0 -fdebug-prefix-map=/var/folders/kp/m9dnkfhx4r9_8dv1cns7m0gh00bkfl/T/go-build113285281=/tmp/go-build -gno-record-gcc-switches -fno-common"
CXX="clang++"
CGO_ENABLED="1"

What did you do?

Looked for instructions online.

What did you expect to see?

The same page to contain information about specifying build constraints, and how to pass those via the go tool.
Information on how to pass multiple flags i.e. separated by spaces?

What did you see instead?

I had to look through source code and tests to find out how multiple tags were passed. The official docs are scarce.
Space-separated tags seems a bit error-prone. If commas are not allowed in tag names, would it be possible to support commas as well?
@bradfitz bradfitz added this to the Go1.9 milestone Dec 16, 2016
@bradfitz bradfitz changed the title Docs to make it more obvious how build tags are meant to be passed cmd/go: docs to make it more obvious how build tags are meant to be passed Dec 16, 2016
@ALTree
Copy link
Member

ALTree commented Mar 7, 2017 •
edited

The official docs are scarce.

This was fixed by 48d7199

would it be possible to support commas as well?

#18800 is also about this (well, in that issue they are suggesting to make the tool complain about commas, while you ask for commas support, but that's the same issue: we just need to decide what to do).

@ALTree ALTree added NeedsDecision Feedback is required from experts, contributors, and/or the community before a change can be made. and removed Documentation labels Mar 7, 2017
@ALTree
Copy link
Member

ALTree commented Jun 1, 2017

Looks like the final decision was to not support comma-separated lists.

16b6bb8 makes the compiler error on commas. We fixed the doc so that it explains the list is space-separated and we fixed the compiler so that it errors when it's not, so closing this.

@ALTree ALTree closed this as completed Jun 1, 2017
@golang golang locked and limited conversation to collaborators Jun 1, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
FrozenDueToAge NeedsDecision Feedback is required from experts, contributors, and/or the community before a change can be made.
Projects
None yet
Milestone
Go1.9
Development

No branches or pull requests
4 participants
@bradfitz @ALTree @mrkane27 @gopherbot