-
Notifications
You must be signed in to change notification settings - Fork 17.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
runtime/pprof: flaky tests (TestMathBigDivide, TestStackBarrierProfiling) #18332
Comments
Odd that we have't seen these on build.golang.org or trybots. But the x/build/cmd/release tool that @broady is using runs |
|
The I can't see why using all.bash would make a difference. It's easy for me to make the tests fail by running 20 of the test programs simultaneously. Not sure what we should do about this. |
We should disable the tests if they can't be made reliable. |
I'll change them to pass if we get at least 10 samples. That is enough to show that the profiler is doing something. |
CL https://golang.org/cl/34507 mentions this issue. |
Failed twice in a row while performing the go1.8beta2 release for linux-amd64, linux-386. freebsd-amd64 failed once, too.
linux-386 also had this one once:
The text was updated successfully, but these errors were encountered: