Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

x/crypto/twofish: twofish_test.go copyright #18311

Closed
keithbostic opened this issue Dec 14, 2016 · 4 comments
Closed

x/crypto/twofish: twofish_test.go copyright #18311

keithbostic opened this issue Dec 14, 2016 · 4 comments

Comments

@keithbostic
Copy link

In the twofish_test.go file, there's the standard Go copyright, along with the comment:

        // These test are derived from http://www.schneier.com/code/ecb_ival.txt

and there's no copyright on that source file, so it's unclear the basis for the inclusion.

That might be worth clarifying.

@bradfitz
Copy link
Contributor

Those have been there since 2011 from 1aec7c7 (when it was still in std).

IANAL but I'm also not terribly concerned due to the source, and that these are just test vectors.

But cc @agl @ianlancetaylor.

@bradfitz bradfitz changed the title twofish_test.go copyright x/crypto/twofish: twofish_test.go copyright Dec 14, 2016
@bradfitz bradfitz added this to the Unreleased milestone Dec 14, 2016
@keithbostic
Copy link
Author

Thank you.

I think it's one of the issues where nobody will ever get sued, and anyone sued would win and the damages are zero, but it's a technical violation and companies that look for copyright violations will flag it, which wastes everyone's time.

If it's trivial to fix, might be worth it.

@agl
Copy link
Contributor

agl commented Dec 14, 2016

While it's the sort of statement that lawyers might cringe at, Schneier says that "Twofish is unpatented, and the source code is uncopyrighted and license-free; it is free for all uses".

@bradfitz
Copy link
Contributor

Thanks, @agl. I think that's sufficient to close this bug. If somebody wants to add a comment line to twofish_test.go and send that CL, that works too.

@golang golang locked and limited conversation to collaborators Dec 14, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

4 participants