Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

x/oauth2/jwt: does not send kid #18307

Closed
tcolgate opened this issue Dec 14, 2016 · 4 comments
Closed

x/oauth2/jwt: does not send kid #18307

tcolgate opened this issue Dec 14, 2016 · 4 comments

Comments

@tcolgate
Copy link
Contributor

tcolgate commented Dec 14, 2016

Please answer these questions before submitting your issue. Thanks!

What version of Go are you using (go version)?

go version go1.7 linux/amd64

What operating system and processor architecture are you using (go env)?

GOARCH="amd64"
GOBIN=""
GOEXE=""
GOHOSTARCH="amd64"
GOHOSTOS="linux"
GOOS="linux"
GOPATH="/home/tristan/go"
GORACE=""
GOROOT="/usr/local/go"
GOTOOLDIR="/usr/local/go/pkg/tool/linux_amd64"
CC="gcc"
GOGCCFLAGS="-fPIC -m64 -pthread -fmessage-length=0 -fdebug-prefix-map=/tmp/go-build824281085=/tmp/go-build -gno-record-gcc-switches"
CXX="g++"
CGO_ENABLED="1"

What did you do?

We are using google.JWTConfigFromJSON to read credentials from a google service account JSON config file. We're are then using these tokens with an internal service. This service requires the kid field in the JWT header, however x/oauth2/jwt does not set the header.

https://play.golang.org/p/xEDTBIsxXZ

If we use google.JWTAccessTokenSourceFromJSON, the correct headers are sent, but that provides no way to set scopes, or get an oauth2.Config

What did you expect to see?

kid header should be set.

What did you see instead?

kid header not set.

@tcolgate
Copy link
Contributor Author

@bradfitz
Copy link
Contributor

@rakyll, who owns JWT stuff?

/cc @broady @adg

@bradfitz bradfitz changed the title x/oauth2/jwt does not send kid x/oauth2/jwt: does not send kid Dec 14, 2016
@rakyll
Copy link
Contributor

rakyll commented Dec 15, 2016

Looking at it.

@tcolgate
Copy link
Contributor Author

Fix has been merged, closing.
Many thanks!

@golang golang locked and limited conversation to collaborators Dec 19, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

4 participants