New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
x/tools/godoc: copying source code should not copy the line numbers as well #18279
Labels
Milestone
Comments
bradfitz
changed the title
godoc: Copying source code should not copy the line numbers as well
x/tools/godoc: copying source code should not copy the line numbers as well
Dec 10, 2016
SGTM. /cc @broady |
After golang.org/cl/34279: |
CL https://golang.org/cl/34279 mentions this issue. |
I've also submitted a CL that changes the CSS only and fixes the problem. I
don't think gopherbot adds "mentions this issue" links for the tools repo.
…On Sat, Dec 10, 2016 at 22:27 Dhananjay Nakrani ***@***.***> wrote:
After golang.org/cl/34279:
[image: screen shot 2016-12-10 at 10 16 10 pm]
<https://cloud.githubusercontent.com/assets/6269279/21078520/c2ce4a50-bf27-11e6-98a7-b96d888d9a1e.png>
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#18279 (comment)>, or mute
the thread
<https://github.com/notifications/unsubscribe-auth/AAOSI7L35OGfb6MwU0dYUuDPjcz5hzrMks5rG5fagaJpZM4LJwpR>
.
|
Ah, never mind. Just saw Kevin's change at http://golang.org/cl/34278 |
Yes, abandoned my change. gopherbot's mention would have saved effort on my side 😅 |
Gopherbot works if you make the reference correctly fully qualified. See other commits in history. |
Neat. Thanks! |
CL https://golang.org/cl/34278 mentions this issue. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
If I go to e.g. https://golang.org/src/path/filepath/path.go?s=4925:4961#L171, and try to copy the source code, the line numbers are included in the highlighted text. In general I'd rather not copy the source code with the line numbers.
If you view the same code on github.com, you can highlight and copy the source code without the line numbers included.
https://github.com/golang/go/blob/master/src/path/filepath/path.go
Happy to work on a fix but it might take a while.
The text was updated successfully, but these errors were encountered: