New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
cmd/link: sigsegv linking some reflection using code #18250
Comments
Paging @crawshaw |
Looks like go.plugin.tabs is being marked as reachable in non-plugins. I can fix that easily enough, which will restore the (incorrect) behavior of 1.7.4. CL soonish. |
Yeah, I'd just blundered my way to that -- it's being marked reachable while laying out the moduledata, which is way too late. I guess the ptab should only be written to the moduledata if it is reachable? |
When -buildmode=plugin it's marked as reachable much earlier, that marking in symtab.go is actually redundant. The problem is it's being used when in other buildmodes. |
Oh heh we have competing fixes, mine is https://go-review.googlesource.com/c/34170/, I'm not especially attached to it though. |
(although having the test is worthwhile) |
CL https://golang.org/cl/34170 mentions this issue. |
CL https://golang.org/cl/34190 mentions this issue. |
I filed #18252 for the problem that is also present in 1.7.4. Not going to get to that today. |
Please answer these questions before submitting your issue. Thanks!
What did you do?
If possible, provide a recipe for reproducing the error.
A complete runnable program is good.
A link on play.golang.org is best.
What did you expect to see?
true
What did you see instead?
Does this issue reproduce with the latest release (go1.7.4)?
Go 1.7 says "false", which is also wrong.
System details
The text was updated successfully, but these errors were encountered: