Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: doesn't use GO_GCFLAGS for tests #18222

Open
randall77 opened this issue Dec 7, 2016 · 2 comments
Open

test: doesn't use GO_GCFLAGS for tests #18222

randall77 opened this issue Dec 7, 2016 · 2 comments
Labels
Builders x/build issues (builders, bots, dashboards) help wanted NeedsFix The path to resolution is known, but the work has not been done.
Milestone

Comments

@randall77
Copy link
Contributor

GO_GCFLAGS only affects the compiler that is invoked directly by the dist tool (I think).
The compiler invoked by test/run.go doesn't have its command line modified by GO_GCFLAGS.
So all of the tests in test/ aren't actually testing what we think they are testing on the modified builders like noopt and ssacheck.

Maybe this is unfixable as a some of the tests in test/ provide their own flags to the compiler. But it surprised me that the ssacheck checks weren't actually running on the ssacheck builder in the test directory.

Maybe there's some way to propagate GO_GCFLAGS that makes sense.

See https://go-review.googlesource.com/c/33909/ for a hack I needed to make this work for randomized value order testing.

@bradfitz @cherrymui @dr2chase

@bradfitz bradfitz added this to the Go1.9 milestone Dec 7, 2016
@bradfitz bradfitz added the Builders x/build issues (builders, bots, dashboards) label Dec 7, 2016
@bradfitz bradfitz added help wanted NeedsFix The path to resolution is known, but the work has not been done. labels May 24, 2017
@bradfitz
Copy link
Contributor

/cc @josharian

@josharian
Copy link
Contributor

Maybe this is unfixable as a some of the tests in test/ provide their own flags to the compiler.

I think this might be so, in the general case. Some flags are incompatible with others in non-trivial ways (which is why cmd/go is such a bear). And the test dir generally probes the weirdest cases we can find.

I'm inclined towards adding hacks to test/run.go to solve particular problems instead, like the hack+problem in CL 33909.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Builders x/build issues (builders, bots, dashboards) help wanted NeedsFix The path to resolution is known, but the work has not been done.
Projects
None yet
Development

No branches or pull requests

4 participants