Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cmd/go: go get -t -u fails with vendor in testcode #18219

Closed
rsc opened this issue Dec 6, 2016 · 3 comments
Closed

cmd/go: go get -t -u fails with vendor in testcode #18219

rsc opened this issue Dec 6, 2016 · 3 comments
Labels
FrozenDueToAge NeedsFix The path to resolution is known, but the work has not been done.
Milestone
Go1.8

Comments

@rsc
Copy link
Contributor

rsc commented Dec 6, 2016 

$ go get -u -t github.com/grafana/grafana/...
package github.com/grafana/grafana/pkg/api
	imports github.com/grafana/grafana/vendor/github.com/smartystreets/goconvey/convey: must be imported as github.com/smartystreets/goconvey/convey
package github.com/grafana/grafana/pkg/components/simplejson
	imports github.com/grafana/grafana/vendor/github.com/bmizerany/assert: must be imported as github.com/bmizerany/assert
package github.com/grafana/grafana/vendor/github.com/bmizerany/assert/example
	imports assert: unrecognized import path "assert" (import path does not begin with hostname)
package github.com/grafana/grafana/vendor/golang.org/x/oauth2/google
	imports google.golang.org/cloud/compute/metadata: code in directory /usr/local/google/home/rsc/go100/tmp/src/google.golang.org/cloud/compute/metadata expects import "cloud.google.com/go/compute/metadata"
package github.com/grafana/grafana/vendor/golang.org/x/oauth2/google
	imports github.com/grafana/grafana/vendor/golang.org/x/oauth2/google: must be imported as golang.org/x/oauth2/google
$

The problem seems to be that the vendored imports are in test code.

For example:

package github.com/grafana/grafana/pkg/components/simplejson
	imports github.com/grafana/grafana/vendor/github.com/bmizerany/assert: must be imported as github.com/bmizerany/assert

But github.com/grafana/grafana/pkg/components/simplejson/simplejson_test.go does import that code as "github.com/bmizerany/assert".
@rsc rsc added this to the Go1.8 milestone Dec 6, 2016
@quentinmit quentinmit added the NeedsFix The path to resolution is known, but the work has not been done. label Dec 6, 2016
@bradfitz
Copy link
Contributor

@rsc, I thought I saw a fix from you for this, but now I don't see it here. Maybe I'm confused. Are you working on this?

@rsc
Copy link
Contributor Author

rsc commented Dec 13, 2016

I am working on this. Didn't make much progress on it Friday.

@gopherbot
Copy link

CL https://golang.org/cl/34201 mentions this issue.

@golang golang locked and limited conversation to collaborators Dec 13, 2017
@rsc rsc removed their assignment Jun 23, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
FrozenDueToAge NeedsFix The path to resolution is known, but the work has not been done.
Projects
None yet
Milestone
Go1.8
Development

No branches or pull requests
4 participants
@bradfitz @rsc @quentinmit @gopherbot