Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

database/sql: QueryContext tests slightly flaky on builders #18115

Closed
mundaym opened this issue Nov 30, 2016 · 1 comment
Closed

database/sql: QueryContext tests slightly flaky on builders #18115

mundaym opened this issue Nov 30, 2016 · 1 comment
Labels
FrozenDueToAge Testing An issue that has been verified to require only test changes, not just a test failure.
Milestone

Comments

@mundaym
Copy link
Member

mundaym commented Nov 30, 2016

Tests on the builders fail very occasionally with an error message like:

sql_test.go:349: expected QueryContext to error with context deadline exceeded but returned <nil>
sql_test.go:145: 1 connections still open after closing DB

On the first page of the current build dashboard there are at least these failures:
freebsd/386 (TestQueryContextWait): https://build.golang.org/log/d1c60620b5dac8f63bec65d725db6b1ecea996a2
freebsd/arm (TestTxContextWait): https://build.golang.org/log/9e00dc66f3195a3953b9f614b32cc08941e906ce
linux/s390x (TestTxContextWait): https://build.golang.org/log/4565d6103bef92bd9a295053b4dde6fe557a689f
openbsd/386 (TestTxContextWait): https://build.golang.org/log/d6c4857060d32d78c38f32d6711748b44d2f8054
openbsd/386 (TestQueryContextWait): https://build.golang.org/log/c5742b78415e0a1412b48762267dd2d28b9abd03
openbsd/amd64 (TestTxContextWait): https://build.golang.org/log/90dd8a9ddced014e803f337affdaba5a61e6db4e
openbsd/amd64 (TestTxContextWait): https://build.golang.org/log/974daafd88d04f790ea43487985718c7cac038e2
windows/386 (TestQueryContextWait): https://build.golang.org/log/062cb7502b6526feae0d057d7616ef2494e82b22

@bradfitz bradfitz added the Testing An issue that has been verified to require only test changes, not just a test failure. label Nov 30, 2016
@bradfitz bradfitz added this to the Go1.8 milestone Nov 30, 2016
@gopherbot
Copy link

CL https://golang.org/cl/33712 mentions this issue.

@golang golang locked and limited conversation to collaborators Nov 30, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
FrozenDueToAge Testing An issue that has been verified to require only test changes, not just a test failure.
Projects
None yet
Development

No branches or pull requests

4 participants