plugin: link error building with plugin package on darwin #18104

captncraig · 2016-11-29T19:44:05Z

Please answer these questions before submitting your issue. Thanks!

What version of Go are you using (`go version`)?

go version devel +5d1c601 Tue Nov 29 05:58:06 2016 +0000 darwin/amd64

What operating system and processor architecture are you using (`go env`)?

GOARCH="amd64"
GOBIN=""
GOEXE=""
GOHOSTARCH="amd64"
GOHOSTOS="darwin"
GOOS="darwin"
GOPATH="/Users/craig/gopath"
GORACE=""
GOROOT="/usr/local/go"
GOTOOLDIR="/usr/local/go/pkg/tool/darwin_amd64"
GCCGO="gccgo"
CC="clang"
GOGCCFLAGS="-fPIC -m64 -pthread -fno-caret-diagnostics -Qunused-arguments -fmessage-length=0 -fdebug-prefix-map=/var/folders/mb/4rxpmz611m773qkhcgz_rx_m0000gn/T/go-build527038733=/tmp/go-build -gno-record-gcc-swi
tches -fno-common"
CXX="clang++"
CGO_ENABLED="1"
PKG_CONFIG="pkg-config"
CGO_CFLAGS="-g -O2"
CGO_CPPFLAGS=""
CGO_CXXFLAGS="-g -O2"
CGO_FFLAGS="-g -O2"
CGO_LDFLAGS="-g -O2"

What did you do?

Trying to add plugin functionality to https://github.com/mholt/caddy

go get github.com/mholt/caddy

simply adding import _ "plugin" to any go file is sufficient to cause the issue for me.

What did you see instead?

go build github.com/mholt/caddy/caddy

# github.com/mholt/caddy/caddy
/usr/local/go/pkg/tool/darwin_amd64/link: running clang failed: exit status 1
duplicate symbol __expand_key_128 in:
    /var/folders/mb/4rxpmz611m773qkhcgz_rx_m0000gn/T/go-link-417611788/go.o
duplicate symbol __expand_key_192a in:
    /var/folders/mb/4rxpmz611m773qkhcgz_rx_m0000gn/T/go-link-417611788/go.o
duplicate symbol __expand_key_192b in:
    /var/folders/mb/4rxpmz611m773qkhcgz_rx_m0000gn/T/go-link-417611788/go.o
duplicate symbol __expand_key_256a in:
    /var/folders/mb/4rxpmz611m773qkhcgz_rx_m0000gn/T/go-link-417611788/go.o
duplicate symbol __expand_key_256b in:
    /var/folders/mb/4rxpmz611m773qkhcgz_rx_m0000gn/T/go-link-417611788/go.o
duplicate symbol _andMask in:
    /var/folders/mb/4rxpmz611m773qkhcgz_rx_m0000gn/T/go-link-417611788/go.o
duplicate symbol _bswapMask in:
    /var/folders/mb/4rxpmz611m773qkhcgz_rx_m0000gn/T/go-link-417611788/go.o
duplicate symbol _gcmPoly in:
    /var/folders/mb/4rxpmz611m773qkhcgz_rx_m0000gn/T/go-link-417611788/go.o
ld: 8 duplicate symbols for architecture x86_64
clang: error: linker command failed with exit code 1 (use -v to see invocation)

some output of go build -x -ldflags "-extldflags -v" github.com/mholt/caddy/caddy:

/usr/local/go/pkg/tool/darwin_amd64/link -o $WORK/github.com/mholt/caddy/caddy/_obj/exe/a.out -L $WORK -L /Users/craig/gopath/pkg/darwin_amd64 -extld=clang -buildmode=exe -buildid=97514994bbed6389d6e33305ba860096
4fc235cc -extldflags -v $WORK/github.com/mholt/caddy/caddy.a
# github.com/mholt/caddy/caddy
/usr/local/go/pkg/tool/darwin_amd64/link: running clang failed: exit status 1
Apple LLVM version 8.0.0 (clang-800.0.38)
Target: x86_64-apple-darwin16.0.0
Thread model: posix
InstalledDir: /Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/bin
 "/Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/bin/ld" -demangle -dynamic -arch x86_64 -macosx_version_min 10.12.0 -syslibroot /Applications/Xcode.app/Contents/Developer/Plat
forms/MacOSX.platform/Developer/SDKs/MacOSX10.12.sdk -o $WORK/github.com/mholt/caddy/caddy/_obj/exe/a.out -headerpad 1144 -flat_namespace -pagezero_size 4000000 /var/folders/mb/4rxpmz611m773qkhcgz_rx_m0000gn/T/go
-link-040389860/go.o /var/folders/mb/4rxpmz611m773qkhcgz_rx_m0000gn/T/go-link-040389860/000000.o /var/folders/mb/4rxpmz611m773qkhcgz_rx_m0000gn/T/go-link-040389860/000001.o /var/folders/mb/4rxpmz611m773qkhcgz_rx_
m0000gn/T/go-link-040389860/000002.o /var/folders/mb/4rxpmz611m773qkhcgz_rx_m0000gn/T/go-link-040389860/000003.o -framework CoreFoundation -framework Security -lpthread -lSystem /Applications/Xcode.app/Contents/D
eveloper/Toolchains/XcodeDefault.xctoolchain/usr/bin/../lib/clang/8.0.0/lib/darwin/libclang_rt.osx.a
duplicate symbol __expand_key_128 in:
    /var/folders/mb/4rxpmz611m773qkhcgz_rx_m0000gn/T/go-link-040389860/go.o
duplicate symbol __expand_key_192a in:
    /var/folders/mb/4rxpmz611m773qkhcgz_rx_m0000gn/T/go-link-040389860/go.o
duplicate symbol __expand_key_192b in:
    /var/folders/mb/4rxpmz611m773qkhcgz_rx_m0000gn/T/go-link-040389860/go.o
duplicate symbol __expand_key_256a in:
    /var/folders/mb/4rxpmz611m773qkhcgz_rx_m0000gn/T/go-link-040389860/go.o
duplicate symbol __expand_key_256b in:
    /var/folders/mb/4rxpmz611m773qkhcgz_rx_m0000gn/T/go-link-040389860/go.o
duplicate symbol _andMask in:
    /var/folders/mb/4rxpmz611m773qkhcgz_rx_m0000gn/T/go-link-040389860/go.o
duplicate symbol _bswapMask in:
    /var/folders/mb/4rxpmz611m773qkhcgz_rx_m0000gn/T/go-link-040389860/go.o
duplicate symbol _gcmPoly in:
    /var/folders/mb/4rxpmz611m773qkhcgz_rx_m0000gn/T/go-link-040389860/go.o
ld: 8 duplicate symbols for architecture x86_64
clang: error: linker command failed with exit code 1 (use -v to see invocation)

It may be an environment issue on my end, but a simpler program that imports plugin seems to compile fine.

The text was updated successfully, but these errors were encountered:

crawshaw · 2016-11-30T13:42:15Z

Those particular symbols are duplicates in caddy. They are defined both in a stdlib package and a third-party package:

src/github.com/lucas-clemente/aes12/asm_amd64.s:TEXT _expand_key_128<>(SB),NOSPLIT,$0
go/src/crypto/aes/asm_amd64.s:TEXT _expand_key_128<>(SB),NOSPLIT,$0

Looks like cmd/asm doesn't mangle the names of <> symbols. In its typical build mode cmd/link is fine gets by, but when DynlinkingGo is true something goes wrong.

bradfitz · 2016-12-15T16:37:59Z

Plugin support was removed from Darwin for Go 1.8. Moving this bug to Go 1.9.

krisnova · 2017-04-08T13:08:21Z

Has anyone started looking at this? Maybe @crawshaw?

I would like to help out here and help code in a solution if at all possible, but don't want to duplicate efforts. Thoughts?

pjebs · 2017-08-01T23:09:38Z

Any news on this?

bradfitz · 2017-08-01T23:15:55Z

Nobody is working on it. There are no improvements in Go 1.9 and no planned improvements for Go 1.10 unless an owner steps up or somebody starts sending fixes.

bradfitz · 2017-08-01T23:16:23Z

Actually, the one change in Go 1.9 is ac29f30

crawshaw · 2017-09-23T14:56:59Z

This has been fixed at HEAD. It appears the duplicate symbols are still in the caddy binary (produced on darwin with import _ "plugin"), but it builds without complaint now:

$ go build github.com/mholt/caddy/caddy
$ objdump -t caddy | grep __expand_key_128
00000000040fd710 l       __TEXT,__text	__expand_key_128
000000000442df40 l       __TEXT,__text	__expand_key_128
$

I'm not sure what CL did this. And whatever the fix is, it's not what I would have done (which is to change cmd/asm to prefix unexported symbols with the package name). But as it's fixed, I'll close this. Please comment if you can reproduce it at HEAD.

benesch · 2017-10-27T00:39:46Z

I wanted a little more closure, so I went digging.

I'm not sure what CL did this. And whatever the fix is, it's not what I would have done (which is to change cmd/asm to prefix unexported symbols with the package name).

Kind of funny you say this, @crawshaw. Git bisect's pointing the finger at 96414ca as the commit that fixed the duplicate symbols.

ianlancetaylor changed the title ~~Link error building with plugin package~~ runtime: link error building with plugin package on darwin Nov 29, 2016

ianlancetaylor changed the title ~~runtime: link error building with plugin package on darwin~~ plugin: link error building with plugin package on darwin Nov 29, 2016

ianlancetaylor added this to the Go1.8Maybe milestone Nov 29, 2016

ianlancetaylor assigned crawshaw Nov 29, 2016

quentinmit added the NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. label Nov 29, 2016

bradfitz modified the milestones: Go1.9, Go1.8Maybe Dec 15, 2016

bradfitz mentioned this issue Feb 17, 2017

plugin: support Darwin again #19167

Closed

krisnova mentioned this issue Feb 21, 2017

Kops Plugin Library kubernetes/kops#958

Closed

bradfitz modified the milestones: Go1.9, Go1.10 Jun 7, 2017

crawshaw closed this as completed Sep 23, 2017

golang locked and limited conversation to collaborators Oct 27, 2018

gopherbot added the FrozenDueToAge label Oct 27, 2018

rsc unassigned crawshaw Jun 23, 2022

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

plugin: link error building with plugin package on darwin #18104

plugin: link error building with plugin package on darwin #18104

captncraig commented Nov 29, 2016

crawshaw commented Nov 30, 2016

bradfitz commented Dec 15, 2016

krisnova commented Apr 8, 2017 •

edited

pjebs commented Aug 1, 2017

bradfitz commented Aug 1, 2017

bradfitz commented Aug 1, 2017

crawshaw commented Sep 23, 2017

benesch commented Oct 27, 2017 •

edited

plugin: link error building with plugin package on darwin #18104

plugin: link error building with plugin package on darwin #18104

Comments

captncraig commented Nov 29, 2016

What version of Go are you using (go version)?

What operating system and processor architecture are you using (go env)?

What did you do?

What did you see instead?

crawshaw commented Nov 30, 2016

bradfitz commented Dec 15, 2016

krisnova commented Apr 8, 2017 • edited

pjebs commented Aug 1, 2017

bradfitz commented Aug 1, 2017

bradfitz commented Aug 1, 2017

crawshaw commented Sep 23, 2017

benesch commented Oct 27, 2017 • edited

What version of Go are you using (`go version`)?

What operating system and processor architecture are you using (`go env`)?

krisnova commented Apr 8, 2017 •

edited

benesch commented Oct 27, 2017 •

edited