Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

database/sql: possible inconsistent handling of types in convertAssign #18101

Closed
kardianos opened this issue Nov 29, 2016 · 2 comments
Closed

database/sql: possible inconsistent handling of types in convertAssign #18101

kardianos opened this issue Nov 29, 2016 · 2 comments
Labels
FrozenDueToAge
Milestone
Go1.9

Comments

@kardianos
Copy link
Contributor

See #15174 (comment)

In convertAssign, we check for numbers but not strings. If this is intentional it should documented why, otherwise consider adding checks for string types.
@kardianos kardianos added this to the Go1.9 milestone Nov 29, 2016
@kardianos kardianos self-assigned this Nov 29, 2016
@kardianos kardianos mentioned this issue Nov 29, 2016
Closed
@kardianos kardianos mentioned this issue Dec 22, 2016
Closed
@kardianos
Copy link
Contributor Author

I think we should add these checks to the default converter for consistency. The code is small and aligns well with the rest of the driver.IsValid checks.

@gopherbot
Copy link

CL https://golang.org/cl/39031 mentions this issue.

lparth pushed a commit to lparth/go that referenced this issue Apr 13, 2017
@kardianos @lparth
database/sql: support scanning into user defined string types
6335483 
User defined numeric types such as "type Int int64" have
been able to be scanned into without a custom scanner by
using the reflect scan code path used to convert between
various numeric types. Add in a path for string types
for symmetry and least surprise.

Fixes golang#18101

Change-Id: I00553bcf021ffe6d95047eca0067ee94b54ff501
Reviewed-on: https://go-review.googlesource.com/39031
Run-TryBot: Daniel Theophanes <kardianos@gmail.com>
TryBot-Result: Gobot Gobot <gobot@golang.org>
Reviewed-by: Brad Fitzpatrick <bradfitz@golang.org>
@golang golang locked and limited conversation to collaborators Mar 31, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
FrozenDueToAge
Projects
None yet
Milestone
Go1.9
Development

No branches or pull requests
2 participants
@kardianos @gopherbot