Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

net/http: document Client's new header copying behavior #18096

Closed
bradfitz opened this issue Nov 29, 2016 · 2 comments
Closed

net/http: document Client's new header copying behavior #18096

bradfitz opened this issue Nov 29, 2016 · 2 comments
Labels
Documentation FrozenDueToAge NeedsFix The path to resolution is known, but the work has not been done.
Milestone
Go1.8

Comments

@bradfitz
Copy link
Contributor

The http Client's new copy-headers-on-redirect behavior is not documented.

It should probably be added to https://tip.golang.org/pkg/net/http/#Client.Do and/or https://tip.golang.org/pkg/net/http/#Client with maybe a pointer to its canonical documentation location from the CheckRedirect field.

@dsnet, can you write this? Otherwise reassign to me if you're swamped.
@bradfitz bradfitz added this to the Go1.8 milestone Nov 29, 2016
@bradfitz bradfitz changed the title net/http: document Client's new cop net/http: document Client's new header copying behavior Nov 29, 2016
@bradfitz
Copy link
Contributor Author

And then update go1.8.html which now has a reference to this bug.

@quentinmit quentinmit added the NeedsFix The path to resolution is known, but the work has not been done. label Nov 29, 2016
@gopherbot
Copy link

CL https://golang.org/cl/33670 mentions this issue.

@golang golang locked and limited conversation to collaborators Nov 30, 2017
@rsc rsc unassigned dsnet Jun 23, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
Documentation FrozenDueToAge NeedsFix The path to resolution is known, but the work has not been done.
Projects
None yet
Milestone
Go1.8
Development

No branches or pull requests
4 participants
@bradfitz @quentinmit @dsnet @gopherbot