-
Notifications
You must be signed in to change notification settings - Fork 17.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
x/tools/cmd/goimports: unnecessary PackageName in ImportSpec #18027
Comments
Intentional. It's more explicit. And it makes future goimports runs faster, not having to scan the "v4" directory to figure out what it means. |
Seems inconsistent that it leaves |
I don't follow. You didn't say anything about that in your bug report. |
|
I still think it's fine. That is: don't mess with people's existing imports if they wrote them by hand or tweaked them by hand. But if we're adding them automatically, then we get to remind them of convention. (dir name == package name) If they don't follow convention, we help readers out. If they don't like it, they can delete it or follow convention. |
The package name is already
sheets
, so there's no need to explicitly name it./cc @bradfitz
The text was updated successfully, but these errors were encountered: