Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cmd/go: go test runner needs a monotonic clock #18021

Closed
tamird opened this issue Nov 22, 2016 · 1 comment
Closed

cmd/go: go test runner needs a monotonic clock #18021

tamird opened this issue Nov 22, 2016 · 1 comment
Labels
FrozenDueToAge NeedsFix The path to resolution is known, but the work has not been done.
Milestone

Comments

@tamird
Copy link
Contributor

tamird commented Nov 22, 2016

On (not as rare as we'd like) occassion, we observe clocks moving backwards in our CI environment.

There are many problems with this, but in particular, it can cause go test to emit negative test runtimes (see cockroachdb/cockroach#10937, which contains:

--- FAIL: TestServerQueryStarvation (-0.13s)
	server_test.go:262: error storing data for series 22, source 4: storage/store.go:2257: rejecting command with timestamp in the future: 1479800017448958100 (281.69074ms ahead)
FAIL

).

This is due to the use of a non-monotonic clock in:

and perhaps others.

This issue is related to #12914.

@rsc
Copy link
Contributor

rsc commented Feb 3, 2017

Fixed along with #12914.

@rsc rsc closed this as completed Feb 3, 2017
@golang golang locked and limited conversation to collaborators Feb 3, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
FrozenDueToAge NeedsFix The path to resolution is known, but the work has not been done.
Projects
None yet
Development

No branches or pull requests

4 participants