Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cmd/go: TestGoEnv failing on Plan 9 #18013

Closed
0intro opened this issue Nov 22, 2016 · 2 comments
Closed

cmd/go: TestGoEnv failing on Plan 9 #18013

0intro opened this issue Nov 22, 2016 · 2 comments
Labels
FrozenDueToAge OS-Plan9
Milestone
Go1.8Maybe

Comments

@0intro
Copy link
Member

0intro commented Nov 22, 2016

Since CL 15457, TestGoEnv is failing on Plan 9.

--- FAIL: TestGoEnv (0.29s)
	go_test.go:260: running testgo [env GOARCH]
	go_test.go:275: standard output:
	go_test.go:276: arm
		
	go_test.go:260: running testgo [env GCCGO]
	go_test.go:275: standard output:
	go_test.go:276: gccgo
		
	go_test.go:260: running testgo [env CGO_CFLAGS]
	go_test.go:275: standard output:
	go_test.go:276: -g -O2
		
	go_test.go:260: running testgo [env CGO_CFLAGS]
	go_test.go:275: standard output:
	go_test.go:276: -foobar
		
	go_test.go:260: running testgo [env CC]
	go_test.go:275: standard output:
	go_test.go:276: 
		
	go_test.go:365: CC not found
	go_test.go:366: pattern gcc not found in standard output
FAIL
FAIL	cmd/go	157.846s

See https://build.golang.org/log/2b5d824ac12e3c635818c518bcc692d1025acb77
@0intro 0intro added this to the Go1.8Maybe milestone Nov 22, 2016
@0intro 0intro self-assigned this Nov 22, 2016
@0intro
Copy link
Member Author

0intro commented Nov 22, 2016

The problem is that the CC, GOGCCFLAGS and CXX environment variables are ignored on Plan 9 in mkEnv.

See https://github.com/golang/go/blob/e9ffda4/src/cmd/go/env.go#L65

@gopherbot
Copy link

CL https://golang.org/cl/33396 mentions this issue.

@golang golang locked and limited conversation to collaborators Nov 22, 2017
@rsc rsc unassigned 0intro Jun 23, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
FrozenDueToAge OS-Plan9
Projects
None yet
Milestone
Go1.8Maybe
Development

No branches or pull requests
2 participants
@0intro @gopherbot