Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

misc/cgo/testcshared: flaky on linux/amd64? #17947

Closed
cherrymui opened this issue Nov 16, 2016 · 6 comments
Closed

misc/cgo/testcshared: flaky on linux/amd64? #17947

cherrymui opened this issue Nov 16, 2016 · 6 comments
Milestone

Comments

@bradfitz
Copy link
Contributor

Yeah, @ianlancetaylor and I were just discussing this. No clue what's going on yet.

@bradfitz bradfitz added this to the Go1.8 milestone Nov 16, 2016
@ianlancetaylor
Copy link
Contributor

I'm pretty sure this must be related to https://golang.org/cl/33142, though I don't see how.

@bcmills

@ianlancetaylor
Copy link
Contributor

The failure, as seen in

https://build.golang.org/log/17502ae096be2c10fedd81dbb9211e195aba2871
https://build.golang.org/log/415ae3c44929c4e3d54987e18fbe382b6aeac3f1
https://storage.googleapis.com/go-build-log/2f40e962/linux-amd64_a884cd40.log

is that the third and last time that misc/cgo/testcshared/main5.c raises SIGIO, the program crashes. At that point the signal handler is supposed to be the C signal handler that was installed before the shared library was dlopened'd. The C signal handler should have been restored by the call to ResetSIGIO which calls signal.Reset(syscall.SIGIO) which eventually calls sigdisable(SIGIO) which calls setsig(sig, fwdSig[sig]) which should have the effect of setting the signal handler back to the value it had when the shared library was loaded.

@gopherbot
Copy link

CL https://golang.org/cl/33331 mentions this issue.

@ianlancetaylor
Copy link
Contributor

I don't know for sure that this is fixed, as I was not able to recreate the problem. Optimistically leaving this closed; let's see if the problem recurs.

@mwhudson
Copy link
Contributor

I saw this a bunch of times on Launchpad builders but haven't seen it since that fix (I have daily builds going now). I'll post here if it reappears.

@golang golang locked and limited conversation to collaborators Nov 20, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

5 participants