Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

net: TestAcceptTimeout flake #17927

Closed
bradfitz opened this issue Nov 15, 2016 · 3 comments
Closed

net: TestAcceptTimeout flake #17927

bradfitz opened this issue Nov 15, 2016 · 3 comments
Labels
FrozenDueToAge NeedsFix The path to resolution is known, but the work has not been done. Testing An issue that has been verified to require only test changes, not just a test failure.
Milestone
Go1.8Maybe

Comments

@bradfitz
Copy link
Contributor

On Darwin: https://build.golang.org/log/27aab1b9073306540c0f424a645f3b2bd326a639

panic: Fail in goroutine after TestAcceptTimeout has completed

goroutine 918 [running]:
panic(0x1236860, 0xc42019a120)
	/var/folders/dx/k53rs1s93538b4x20g46cj_w0000gn/T/workdir/go/src/runtime/panic.go:531 +0x1cf
testing.(*common).Fail(0xc4205e02a0)
	/var/folders/dx/k53rs1s93538b4x20g46cj_w0000gn/T/workdir/go/src/testing/testing.go:464 +0x119
testing.(*common).Error(0xc4205e02a0, 0xc42020df40, 0x1, 0x1)
	/var/folders/dx/k53rs1s93538b4x20g46cj_w0000gn/T/workdir/go/src/testing/testing.go:531 +0x6f
net.TestAcceptTimeout.func1(0x1399d80, 0xc4201c8080, 0x1399740, 0xc4200b6010, 0xc4205e02a0)
	/var/folders/dx/k53rs1s93538b4x20g46cj_w0000gn/T/workdir/go/src/net/timeout_test.go:176 +0x19a
created by net.TestAcceptTimeout
	/var/folders/dx/k53rs1s93538b4x20g46cj_w0000gn/T/workdir/go/src/net/timeout_test.go:182 +0x88f
FAIL	net	2.547s

/cc @mikioh
@bradfitz bradfitz added the Testing An issue that has been verified to require only test changes, not just a test failure. label Nov 15, 2016
@bradfitz bradfitz added this to the Go1.8Maybe milestone Nov 15, 2016
@gopherbot
Copy link

CL https://golang.org/cl/33257 mentions this issue.

@quentinmit quentinmit added the NeedsFix The path to resolution is known, but the work has not been done. label Nov 16, 2016
@bradfitz
Copy link
Contributor Author

Still flaky. I opened #17948 with the new failures.

@gopherbot
Copy link

CL https://golang.org/cl/33330 mentions this issue.

gopherbot pushed a commit that referenced this issue Nov 16, 2016
@bradfitz
net: disable TestAcceptTimeout for now
8dc47e3 
It's too flaky and doing more harm than good.

Disable it until it can be made reliable.

Updates #17948
Updates #17927

Change-Id: Iaab7f09a4060da377fcd3ca2262527fef50c558d
Reviewed-on: https://go-review.googlesource.com/33330
Reviewed-by: Brad Fitzpatrick <bradfitz@golang.org>
@golang golang locked and limited conversation to collaborators Nov 16, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
FrozenDueToAge NeedsFix The path to resolution is known, but the work has not been done. Testing An issue that has been verified to require only test changes, not just a test failure.
Projects
None yet
Milestone
Go1.8Maybe
Development

No branches or pull requests
3 participants
@bradfitz @quentinmit @gopherbot