-
Notifications
You must be signed in to change notification settings - Fork 18k
runtime: add a comment which briefly mentions where (or how) g_stackguard0
is defined
#17915
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
It looks like it's just a local variable name. /cc @ianlancetaylor |
@bradfitz It looks like the symbol is generated by
|
You are asking where the assembler constant |
@ianlancetaylor @bradfitz Indeed, adding a comment does not help much as I thought (as I brought up the issue before I found out the answer). Maybe the assembler deserves a more capable language which won't need such kind of cleverness in the future. Thanks for your responses and feel free to close the issue. |
I don't think we could make the assembler more capable to eliminate the
auto-generated header unless we embed a copy of cmd/compile inside cmd/asm.
|
I guess https://golang.org/doc/asm could/should mention asmhdr? Would give
people a chance to figure out what's going on at least.
|
Yeah, we could document go_asm.h in doc/asm, but my concern is that it will
not help much as it's such a rarely used feature that I don't know any
package besides runtime uses it.
|
Am I missing something obvious? I attempted but failed to locate the definition of the symbol with
grep
andack
.A brief comment will certainly save time for people who are trying to learn the runtime's internal.
The text was updated successfully, but these errors were encountered: