Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

net/http: TestServerSetKeepAlivesEnabledClosesConns flaking with "idle count after SetKeepAlivesEnabled called = 1; want 0" #17754

Closed
mdempsky opened this issue Nov 2, 2016 · 2 comments
Closed

net/http: TestServerSetKeepAlivesEnabledClosesConns flaking with "idle count after SetKeepAlivesEnabled called = 1; want 0" #17754

mdempsky opened this issue Nov 2, 2016 · 2 comments
Labels
FrozenDueToAge
Milestone
Go1.8

Comments

@mdempsky
Copy link
Member

mdempsky commented Nov 2, 2016 •
edited

Seen several times today on trybots:

Failed on linux-amd64: https://storage.googleapis.com/go-build-log/8b2acc47/linux-amd64_eefbc2f7.log
Failed on openbsd-amd64-gce58: https://storage.googleapis.com/go-build-log/8b2acc47/openbsd-amd64-gce58_5cfee96b.log
Failed on windows-amd64-gce: https://storage.googleapis.com/go-build-log/8a2800a1/windows-amd64-gce_c6ab9d3e.log

/cc @bradfitz
@bradfitz bradfitz self-assigned this Nov 2, 2016
@bradfitz bradfitz added this to the Go1.8 milestone Nov 2, 2016
@bradfitz bradfitz mentioned this issue Nov 3, 2016
Closed
@gopherbot
Copy link

CL https://golang.org/cl/32587 mentions this issue.

@gopherbot
Copy link

CL https://golang.org/cl/33141 mentions this issue.

gopherbot pushed a commit that referenced this issue Nov 11, 2016
@bradfitz
net/http: make Server respect shutdown state after handler finishes
9f9d834 
If the Server's Shutdown (or SetKeepAlivesEnabled) method was called
while a connection was in a Handler, but after the headers had been
written, the connection was not later closed.

Fixes #9478
Updates #17754 (reverts that workaround)

Change-Id: I65324ab8217373fbb38e12e2b8bffd0a91806072
Reviewed-on: https://go-review.googlesource.com/33141
Reviewed-by: Ian Lance Taylor <iant@golang.org>
@golang golang locked and limited conversation to collaborators Nov 11, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
FrozenDueToAge
Projects
None yet
Milestone
Go1.8
Development

No branches or pull requests
3 participants
@bradfitz @mdempsky @gopherbot