Skip to content

x/crypto/acme/autocert: lock usage around certState is bogus and error prone #17749

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
niemeyer opened this issue Nov 2, 2016 · 1 comment
Open

x/crypto/acme/autocert: lock usage around certState is bogus and error prone #17749

niemeyer opened this issue Nov 2, 2016 · 1 comment
Labels
NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one.
Milestone
Unreleased

Comments

@niemeyer
Copy link
Contributor

niemeyer commented Nov 2, 2016

The use of locks around certState is pretty confusing. The certState method returns the state value either locked or not, which means the call site has no idea about what it got. Then, there's a locked boolean field which is used to decide whether to lock it again or release the existing lock. That's both error prone and wrong from a concurrent memory access perspective.
@dsnet dsnet added this to the Unreleased milestone Nov 3, 2016
@gopherbot
Copy link
Contributor

CL https://golang.org/cl/41731 mentions this issue.

@seankhliao seankhliao added the NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. label Jul 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one.
Projects
None yet
Milestone
Unreleased
Development

No branches or pull requests
4 participants
@niemeyer @dsnet @gopherbot @seankhliao