Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

x/tools/go/ssa: generate testmain package compatible with new testing.TestMain #17722

Closed
alandonovan opened this issue Nov 1, 2016 · 2 comments
Closed

x/tools/go/ssa: generate testmain package compatible with new testing.TestMain #17722

alandonovan opened this issue Nov 1, 2016 · 2 comments
Labels
FrozenDueToAge
Milestone
Unreleased

Comments

@alandonovan
Copy link
Contributor

CL https://go-review.googlesource.com/c/32455/ changes the type of the testing.TestMain function in order to break a dependency. The ssa package will need to be updated to work with either the old or the new signature, and will need to be tested on Go 1.7 and Go 1.8.
@alandonovan alandonovan self-assigned this Nov 1, 2016
@rakyll rakyll changed the title golang.org/x/tools/go/ssa: generate testmain package compatible with new testing.TestMain. x/tools/go/ssa: generate testmain package compatible with new testing.TestMain Nov 1, 2016
@rakyll rakyll added this to the Unreleased milestone Nov 1, 2016
@alandonovan alandonovan reopened this Nov 1, 2016
@alandonovan
Copy link
Contributor Author

(Sorry, too many browser tabs.)

@gopherbot
Copy link

CL https://golang.org/cl/32888 mentions this issue.

@golang golang locked and limited conversation to collaborators Nov 8, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
FrozenDueToAge
Projects
None yet
Milestone
Unreleased
Development

No branches or pull requests
3 participants
@rakyll @alandonovan @gopherbot